VTVDA: Verify |picture_id| in ResusePictureBuffer().

VTVDA: Verify |picture_id| in ResusePictureBuffer().

BUG=637320
Committed: https://crrev.com/c925db56332eff18cee034f0836a0406a3b62ac8
Cr-Commit-Position: refs/heads/master@{#411834}

[sandersd (OOO until July 31), 2016-08-12 21:58:21]

sandersd@chromium.org changed reviewers:
+ ccameron@chromium.org

[sandersd (OOO until July 31), 2016-08-12 21:58:50]

The CQ bit was checked by sandersd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 21:59:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sandersd (OOO until July 31), 2016-08-12 21:59:52]

Description was changed from

==========
VTVDA: Verify |picture_id| first in ResusePictureBuffer().

Also adds DCHECKs that find() never returns end() in VTVDA.

BUG=637320
==========

to

==========
VTVDA: Verify |picture_id| first in ResusePictureBuffer().

Also adds DCHECKs that find() never returns end() in VTVDA.

BUG=637320
==========

[sandersd (OOO until July 31), 2016-08-12 21:59:52]

sandersd@chromium.org changed reviewers:
+ ochang@chromium.org

[sandersd (OOO until July 31), 2016-08-12 21:59:52]

sandersd@chromium.org changed required reviewers:
+ ccameron@chromium.org

[sandersd (OOO until July 31), 2016-08-12 22:00:22]

+ochang@ as optional reviewer.

[sandersd (OOO until July 31), 2016-08-12 22:03:19]

https://codereview.chromium.org/2244853002/diff/1/media/gpu/vt_video_decode_a...
File media/gpu/vt_video_decode_accelerator_mac.cc (left):

https://codereview.chromium.org/2244853002/diff/1/media/gpu/vt_video_decode_a...
media/gpu/vt_video_decode_accelerator_mac.cc:872:
picture_info->gl_image->Destroy(false);
ccameron@: Are we relying on this to always happen? My change may remove this
for already-discarded picture buffers. If it does need to run in that case, do
we also need a Destroy()-time loop to do this to the rest?

[commit-bot: I haz the power, 2016-08-12 22:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 22:46:54]

Dry run: Exceeded global retry quota

[sandersd (OOO until July 31), 2016-08-12 22:56:01]

Description was changed from

==========
VTVDA: Verify |picture_id| first in ResusePictureBuffer().

Also adds DCHECKs that find() never returns end() in VTVDA.

BUG=637320
==========

to

==========
VTVDA: Verify |picture_id| in ResusePictureBuffer().

BUG=637320
==========

[sandersd (OOO until July 31), 2016-08-12 22:56:39]

https://codereview.chromium.org/2244853002/diff/1/media/gpu/vt_video_decode_a...
File media/gpu/vt_video_decode_accelerator_mac.cc (left):

https://codereview.chromium.org/2244853002/diff/1/media/gpu/vt_video_decode_a...
media/gpu/vt_video_decode_accelerator_mac.cc:872:
picture_info->gl_image->Destroy(false);
On 2016/08/12 22:03:19, sandersd wrote:
> ccameron@: Are we relying on this to always happen? My change may remove this
> for already-discarded picture buffers. If it does need to run in that case, do
> we also need a Destroy()-time loop to do this to the rest?

I realized there was a better factoring without this difference, should be
behaviorally identical now.

[sandersd (OOO until July 31), 2016-08-12 22:57:52]

The CQ bit was checked by sandersd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 22:58:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-08-12 23:50:04]

lgtm

[commit-bot: I haz the power, 2016-08-13 00:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 00:29:05]

Dry run: This issue passed the CQ dry run.

[sandersd (OOO until July 31), 2016-08-13 00:36:01]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2016-08-13 00:36:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 00:40:50]

Description was changed from

==========
VTVDA: Verify |picture_id| in ResusePictureBuffer().

BUG=637320
==========

to

==========
VTVDA: Verify |picture_id| in ResusePictureBuffer().

BUG=637320
==========

[commit-bot: I haz the power, 2016-08-13 00:40:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-13 00:46:50]

Description was changed from

==========
VTVDA: Verify |picture_id| in ResusePictureBuffer().

BUG=637320
==========

to

==========
VTVDA: Verify |picture_id| in ResusePictureBuffer().

BUG=637320

Committed: https://crrev.com/c925db56332eff18cee034f0836a0406a3b62ac8
Cr-Commit-Position: refs/heads/master@{#411834}
==========

[commit-bot: I haz the power, 2016-08-13 00:46:51]

Patchset 2 (id:??) landed as
https://crrev.com/c925db56332eff18cee034f0836a0406a3b62ac8
Cr-Commit-Position: refs/heads/master@{#411834}