Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp

Issue 2244813002: LongTaskTiming: add idl, Experiment flag, PerformanceEntry and basic implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
diff --git a/third_party/WebKit/public/platform/WebEffectiveConnectionType.h b/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
similarity index 78%
copy from third_party/WebKit/public/platform/WebEffectiveConnectionType.h
copy to third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
index 648777e7bd1b0fcaf51a9a06d98f141795e988ab..c6fb7e5a21d2d78f8c740187b8142a0ec405fad1 100644
--- a/third_party/WebKit/public/platform/WebEffectiveConnectionType.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2016 Google Inc. All rights reserved.
+ * Copyright (C) 2016 Intel Inc. All rights reserved.
haraken 2016/08/17 01:15:48 Why are you adding a copyright for Intel? Either
panicker 2016/08/17 19:00:09 Other similar files in this directory have this co
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -28,21 +29,23 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebEffectiveConnectionType_h
-#define WebEffectiveConnectionType_h
+#include "core/timing/PerformanceLongTaskTiming.h"
namespace blink {
-enum class WebEffectiveConnectionType {
- TypeUnknown,
- TypeOffline,
- TypeSlow2G,
- Type2G,
- Type3G,
- Type4G,
- TypeBroadband
-};
+PerformanceLongTaskTiming::PerformanceLongTaskTiming(
+ double startTime, double endTime, String frameContextUrl)
+ : PerformanceEntry(frameContextUrl, "longtask", startTime, endTime)
+{
+}
-} // namespace blink
+PerformanceLongTaskTiming::~PerformanceLongTaskTiming()
+{
+}
+
+DEFINE_TRACE(PerformanceLongTaskTiming)
+{
+ PerformanceEntry::trace(visitor);
+}
-#endif // WebEffectiveConnectionType_h
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698