third_party/WebKit/Source/core/timing/Performance.idl - Issue 2244813002: LongTaskTiming: add idl, Experiment flag, PerformanceEntry and basic implementation

Side by Side Diff: third_party/WebKit/Source/core/timing/Performance.idl

Issue 2244813002: LongTaskTiming: add idl, Experiment flag, PerformanceEntry and basic implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/events/EventTypeNames.in ('k') | third_party/WebKit/Source/core/timing/PerformanceBase.h » ('j') | third_party/WebKit/Source/core/timing/PerformanceBase.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 * Copyright (C) 2012 Intel Inc. All rights reserved.	3 * Copyright (C) 2012 Intel Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions are	6 * modification, are permitted provided that the following conditions are

7 * met:	7 * met:

8 *	8 *

9 * * Redistributions of source code must retain the above copyright	9 * * Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69	69

70 [MeasureAs=UnprefixedUserTiming, RaisesException] void measure(DOMString mea sureName, optional DOMString startMark = null, optional DOMString endMark = null );	70 [MeasureAs=UnprefixedUserTiming, RaisesException] void measure(DOMString mea sureName, optional DOMString startMark = null, optional DOMString endMark = null );

71 [MeasureAs=UnprefixedUserTiming] void clearMeasures(optional DOMString measu reName = null);	71 [MeasureAs=UnprefixedUserTiming] void clearMeasures(optional DOMString measu reName = null);

72	72

73 // Frame Timing	73 // Frame Timing

74 // https://w3c.github.io/frame-timing/#extensions-performance-interface	74 // https://w3c.github.io/frame-timing/#extensions-performance-interface

75 [RuntimeEnabled=FrameTimingSupport, MeasureAs=PerformanceFrameTiming] void c learFrameTimings();	75 [RuntimeEnabled=FrameTimingSupport, MeasureAs=PerformanceFrameTiming] void c learFrameTimings();

76 [RuntimeEnabled=FrameTimingSupport, MeasureAs=PerformanceFrameTiming] void s etFrameTimingBufferSize(unsigned long maxSize);	76 [RuntimeEnabled=FrameTimingSupport, MeasureAs=PerformanceFrameTiming] void s etFrameTimingBufferSize(unsigned long maxSize);

77 [RuntimeEnabled=FrameTimingSupport] attribute EventHandler onframetimingbuff erfull;	77 [RuntimeEnabled=FrameTimingSupport] attribute EventHandler onframetimingbuff erfull;

78	78

	79 // Long Task Timing

	80 [RuntimeEnabled=LongTaskObserver] void clearLongTaskTimings();
	haraken 2016/08/17 01:15:48 Would it make more sense to rename this to clearLo Would it make more sense to rename this to clearLongTaskTimingBuffer? (for consistency with the following two methods) panicker 2016/08/17 19:00:09 Hmm not sure, I've tried to be consistent with the Show quoted text On 2016/08/17 01:15:48, haraken wrote: > > Would it make more sense to rename this to clearLongTaskTimingBuffer? (for > consistency with the following two methods) Hmm not sure, I've tried to be consistent with the other perf-entries in this file: clearResourceTimings(), clearMarks() etc.
	81 [RuntimeEnabled=LongTaskObserver] void setLongTaskTimingBufferSize(unsigned long maxSize);

	82 [RuntimeEnabled=LongTaskObserver] attribute EventHandler onlongtasktimingbuf ferfull;

	83

79 // TODO(foolip): There is no spec for the Memory Info API, see blink-dev:	84 // TODO(foolip): There is no spec for the Memory Info API, see blink-dev:

80 // https://groups.google.com/a/chromium.org/d/msg/blink-dev/g5YRCGpC9vs/b4OJ z71NmPwJ	85 // https://groups.google.com/a/chromium.org/d/msg/blink-dev/g5YRCGpC9vs/b4OJ z71NmPwJ

81 [Measure] readonly attribute MemoryInfo memory;	86 [Measure] readonly attribute MemoryInfo memory;

82 };	87 };

OLD	NEW