Issue 22448003: Remove CHECK when setting the plugin window property. There could be a race condition where the win…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22448003: Remove CHECK when setting the plugin window property. There could be a race condition where the win… (Closed)

Created:
7 years, 4 months ago by jam

Modified:
7 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove CHECK when setting the plugin window property. There could be a race condition where the window is destroyed as we're setting that property (since the destructino happens in the plugin process). BUG=248383 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215947

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/renderer_host/render_widget_host_view_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

I looked into ViewProp per your suggestion. But I think it's not possible to use ...

7 years, 4 months ago (2013-08-06 16:56:37 UTC) #1

LGTM

Expand Messages | Collapse Messages