chrome/browser/ui/webui/snippets_internals_message_handler.cc - Issue 2244793002: Remove deleted offline page suggestions from opened NTPs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/snippets_internals_message_handler.cc

Issue 2244793002: Remove deleted offline page suggestions from opened NTPs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Michael's and Marc's comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/snippets_internals_message_handler.h ('k') | components/ntp_snippets/category_factory.h » ('j') | components/ntp_snippets/content_suggestions_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/snippets_internals_message_handler.cc

diff --git a/chrome/browser/ui/webui/snippets_internals_message_handler.cc b/chrome/browser/ui/webui/snippets_internals_message_handler.cc

index 4efe2c9738cd61747e432333512923c1a827688b..841224a5f25c4a116f8f78aaefe2b0f141c6eb00 100644

--- a/chrome/browser/ui/webui/snippets_internals_message_handler.cc

+++ b/chrome/browser/ui/webui/snippets_internals_message_handler.cc

@@ -128,6 +128,14 @@ void SnippetsInternalsMessageHandler::OnCategoryStatusChanged(

SendContentSuggestions();

}

+void SnippetsInternalsMessageHandler::OnSuggestionInvalidated(

+ ntp_snippets::Category category,

+ const std::string& suggestion_id) {

+ if (!dom_loaded_)

+ return;

+ SendContentSuggestions();

void SnippetsInternalsMessageHandler::ContentSuggestionsServiceShutdown() {}

void SnippetsInternalsMessageHandler::HandleRefreshContent(