Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2244793002: Remove deleted offline page suggestions from opened NTPs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust MockContentSuggestionsProvider Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index e869167a4aa015850727c9b84aebda58ea5f1d41..3995eaf66a99be0b46028420d4572a3225fbe89c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -204,6 +204,13 @@ public class NewTabPageAdapter extends Adapter<NewTabPageViewHolder>
}
@Override
+ public void onSuggestionInvalidated(@CategoryInt int category, String suggestionId) {
+ if (!mSections.containsKey(category)) return;
+ mSections.get(category).removeSuggestionById(suggestionId);
+ updateGroups();
+ }
+
+ @Override
@NewTabPageItem.ViewType
public int getItemViewType(int position) {
return getItems().get(position).getType();
@@ -348,7 +355,7 @@ public class NewTabPageAdapter extends Adapter<NewTabPageViewHolder>
mSuggestionsSource.dismissSuggestion(suggestion);
SuggestionsSection section = (SuggestionsSection) getGroup(position);
- section.dismissSuggestion(suggestion);
+ section.removeSuggestion(suggestion);
if (section.hasSuggestions()) {
// If one of many suggestions was dismissed, it's a simple item removal, which can be
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698