Android: Don't evict thumbnails for last visible tab on stop

Android: Don't evict thumbnails for last visible tab on stop

When the activity stops (or rather the context goes away and
resident textures incl. UI resources are evicted), don't
evict the thumbnails for the tab that was visible *if*
the bitmap is still available and wasn't uploaded to a texture
yet.

Also, don't force the UIResource to be created proactively
when the ETC1 compression completes *if* there are no running
activities, since it's racy with uploading it into
the old context that's going away, while throwing away the bitmap.

When there's critical memory pressure, free all thumbnails.

BUG=636630
Committed: https://crrev.com/1d3bd9ca2dee42d4908ebe358f98df12c6aca327
Cr-Commit-Position: refs/heads/master@{#414789}

[no sievers, 2016-08-13 00:50:41]

The CQ bit was checked by sievers@chromium.org to run a CQ dry run

[no sievers, 2016-08-13 00:50:56]

Description was changed from

==========
Android: Don't evict thumbnails for last visible tab on stop

When the activity stops (or rather the context goes away and
resident textures incl. UI resources are evicted), don't
evict the thumbnails for the tab that was visible *if*
the bitmap is still available and wasn't uploaded to a texture
yet.

Also, don't force the UIResource to be created proactively
when the ETC1 compression completes *if* there are no running
activities, since it's racy with uploading it into
the old context that's going away, while throwing away the bitmap.

When there's critical memory pressure, free all thumbnails.

BUG=636630
==========

to

==========
Android: Don't evict thumbnails for last visible tab on stop

When the activity stops (or rather the context goes away and
resident textures incl. UI resources are evicted), don't
evict the thumbnails for the tab that was visible *if*
the bitmap is still available and wasn't uploaded to a texture
yet.

Also, don't force the UIResource to be created proactively
when the ETC1 compression completes *if* there are no running
activities, since it's racy with uploading it into
the old context that's going away, while throwing away the bitmap.

When there's critical memory pressure, free all thumbnails.

BUG=636630
==========

[no sievers, 2016-08-13 00:50:56]

sievers@chromium.org changed reviewers:
+ dtrainor@chromium.org

[no sievers, 2016-08-13 00:51:05]

dtrainor, ptal!

[commit-bot: I haz the power, 2016-08-13 00:51:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 01:35:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 01:35:27]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-08-16 02:47:30]

lgtm!

https://codereview.chromium.org/2244783005/diff/1/chrome/browser/android/thum...
File chrome/browser/android/thumbnail/thumbnail_cache.cc (right):

https://codereview.chromium.org/2244783005/diff/1/chrome/browser/android/thum...
chrome/browser/android/thumbnail/thumbnail_cache.cc:451: TabId last_tab =
visible_ids_.empty() ? 0 : visible_ids_.front();
IIRC think 0 is a valid id.  -1?

[no sievers, 2016-08-26 18:56:49]

Patchset #3 (id:40001) has been deleted

[no sievers, 2016-08-26 19:00:20]

https://codereview.chromium.org/2244783005/diff/1/chrome/browser/android/thum...
File chrome/browser/android/thumbnail/thumbnail_cache.cc (right):

https://codereview.chromium.org/2244783005/diff/1/chrome/browser/android/thum...
chrome/browser/android/thumbnail/thumbnail_cache.cc:451: TabId last_tab =
visible_ids_.empty() ? 0 : visible_ids_.front();
On 2016/08/16 02:47:29, David Trainor wrote:
> IIRC think 0 is a valid id.  -1?

Done.

[no sievers, 2016-08-26 19:07:43]

The CQ bit was checked by sievers@chromium.org

[no sievers, 2016-08-26 19:07:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2244783005/#ps60001
(title: "Android: Don't evict thumbnails for last visible tab on stop")

[commit-bot: I haz the power, 2016-08-26 19:08:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 19:58:35]

Description was changed from

==========
Android: Don't evict thumbnails for last visible tab on stop

When the activity stops (or rather the context goes away and
resident textures incl. UI resources are evicted), don't
evict the thumbnails for the tab that was visible *if*
the bitmap is still available and wasn't uploaded to a texture
yet.

Also, don't force the UIResource to be created proactively
when the ETC1 compression completes *if* there are no running
activities, since it's racy with uploading it into
the old context that's going away, while throwing away the bitmap.

When there's critical memory pressure, free all thumbnails.

BUG=636630
==========

to

==========
Android: Don't evict thumbnails for last visible tab on stop

When the activity stops (or rather the context goes away and
resident textures incl. UI resources are evicted), don't
evict the thumbnails for the tab that was visible *if*
the bitmap is still available and wasn't uploaded to a texture
yet.

Also, don't force the UIResource to be created proactively
when the ETC1 compression completes *if* there are no running
activities, since it's racy with uploading it into
the old context that's going away, while throwing away the bitmap.

When there's critical memory pressure, free all thumbnails.

BUG=636630
==========

[commit-bot: I haz the power, 2016-08-26 19:58:36]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-26 20:01:35]

Description was changed from

==========
Android: Don't evict thumbnails for last visible tab on stop

When the activity stops (or rather the context goes away and
resident textures incl. UI resources are evicted), don't
evict the thumbnails for the tab that was visible *if*
the bitmap is still available and wasn't uploaded to a texture
yet.

Also, don't force the UIResource to be created proactively
when the ETC1 compression completes *if* there are no running
activities, since it's racy with uploading it into
the old context that's going away, while throwing away the bitmap.

When there's critical memory pressure, free all thumbnails.

BUG=636630
==========

to

==========
Android: Don't evict thumbnails for last visible tab on stop

When the activity stops (or rather the context goes away and
resident textures incl. UI resources are evicted), don't
evict the thumbnails for the tab that was visible *if*
the bitmap is still available and wasn't uploaded to a texture
yet.

Also, don't force the UIResource to be created proactively
when the ETC1 compression completes *if* there are no running
activities, since it's racy with uploading it into
the old context that's going away, while throwing away the bitmap.

When there's critical memory pressure, free all thumbnails.

BUG=636630

Committed: https://crrev.com/1d3bd9ca2dee42d4908ebe358f98df12c6aca327
Cr-Commit-Position: refs/heads/master@{#414789}
==========

[commit-bot: I haz the power, 2016-08-26 20:01:36]

Patchset 3 (id:??) landed as
https://crrev.com/1d3bd9ca2dee42d4908ebe358f98df12c6aca327
Cr-Commit-Position: refs/heads/master@{#414789}