Issue 2244783004: DevTools: Refactor Profiler domain interface

Issue 2244783004: DevTools: Refactor Profiler domain interface (Closed)

Created:
4 years, 4 months ago by alph

Modified:
4 years, 4 months ago

Reviewers:
dgozman, pfeldman

CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: Refactor Profiler domain interface Flatten nodes into an array. Committed: https://crrev.com/3b17e107b6801bc18861154e707dfa57ba23a909 Cr-Commit-Position: refs/heads/master@{#412613}

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+207 lines, -190 lines)			Patch
M	third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profile.html	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-large-tree-search.html	View	4 chunks	+24 lines, -27 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-times.html	View	4 chunks	+63 lines, -66 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-flame-chart-overview.html	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-native-nodes-filter.html	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-js-line-level-profile.html	View	2 chunks	+44 lines, -44 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html	View	1 chunk	+20 lines, -16 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js	View	4 chunks	+13 lines, -14 lines	0 comments	Download
M	third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp	View	2 chunks	+15 lines, -6 lines	0 comments	Download
M	third_party/WebKit/Source/platform/v8_inspector/js_protocol.json	View	5 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 14 (7 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244783004/1

4 years, 4 months ago (2016-08-17 17:08:32 UTC) #9

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/3b17e107b6801bc18861154e707dfa57ba23a909 Cr-Commit-Position: refs/heads/master@{#412613}

4 years, 4 months ago (2016-08-17 19:37:23 UTC) #12

paulirish

I believe this may break a number of other protocol clients: https://github.com/search?utf8=%E2%9C%93&q=%22profiler.start%22+%22profiler.stop%22+hitcount+children&type=Code&ref=searchresults Does it also ...

4 years, 4 months ago (2016-08-17 20:04:59 UTC) #13

alph

4 years, 4 months ago (2016-08-17 20:44:02 UTC) #14

Message was sent while issue was closed.

On 2016/08/17 20:04:59, paulirish wrote:
> I believe this may break a number of other protocol clients:
>
https://github.com/search?utf8=%E2%9C%93&q=%22profiler.start%22+%22profiler.s...

Yeah. I can see there are two projects. They need to be updated to work with the
new API.

> Does it also break compatibility with the .cpuprofile format? (There are many
> external tools that generate it for viewing in Chrome)

I'm going to upload the format compatibility patch shortly. So the new Chrome
will be able to read the old profiles.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages