Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: services/video_capture/video_capture_device_proxy_impl.h

Issue 2244773002: Video Capture Mojo (1.4c): Handle Subsequent Access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FillServicePart2
Patch Set: mcasas' comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_IMPL_H_ 5 #ifndef SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_IMPL_H_
6 #define SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_IMPL_H_ 6 #define SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_IMPL_H_
7 7
8 #include "media/capture/video/video_capture_device.h" 8 #include "media/capture/video/video_capture_device.h"
9 #include "services/video_capture/public/interfaces/video_capture_device_proxy.mo jom.h" 9 #include "services/video_capture/public/interfaces/video_capture_device_proxy.mo jom.h"
10 10
11 namespace video_capture { 11 namespace video_capture {
12 12
13 // Implementation of mojom::VideoCaptureDeviceProxy backed by a given instance 13 // Implementation of mojom::VideoCaptureDeviceProxy backed by a given instance
14 // of media::VideoCaptureDevice. 14 // of media::VideoCaptureDevice.
15 class VideoCaptureDeviceProxyImpl : public mojom::VideoCaptureDeviceProxy { 15 class VideoCaptureDeviceProxyImpl : public mojom::VideoCaptureDeviceProxy {
16 public: 16 public:
17 VideoCaptureDeviceProxyImpl( 17 VideoCaptureDeviceProxyImpl(
18 std::unique_ptr<media::VideoCaptureDevice> device); 18 std::unique_ptr<media::VideoCaptureDevice> device);
19 ~VideoCaptureDeviceProxyImpl() override; 19 ~VideoCaptureDeviceProxyImpl() override;
20 20
21 // mojom::VideoCaptureDeviceProxy: 21 // mojom::VideoCaptureDeviceProxy:
22 void Start(mojom::VideoCaptureFormatPtr requested_format, 22 void Start(mojom::VideoCaptureFormatPtr requested_format,
23 mojom::ResolutionChangePolicy resolution_change_policy, 23 mojom::ResolutionChangePolicy resolution_change_policy,
24 mojom::PowerLineFrequency power_line_frequency, 24 mojom::PowerLineFrequency power_line_frequency,
25 mojom::VideoCaptureDeviceClientPtr client) override; 25 mojom::VideoCaptureDeviceClientPtr client) override;
26 26
27 void Stop();
28
27 // TODO(chfremer): Consider using Mojo type mapping instead of conversion 29 // TODO(chfremer): Consider using Mojo type mapping instead of conversion
28 // methods. 30 // methods.
29 // https://crbug.com/642387 31 // https://crbug.com/642387
30 static media::VideoCaptureFormat ConvertFromMojoToMedia( 32 static media::VideoCaptureFormat ConvertFromMojoToMedia(
31 mojom::VideoCaptureFormatPtr format); 33 mojom::VideoCaptureFormatPtr format);
32 static media::VideoPixelFormat ConvertFromMojoToMedia( 34 static media::VideoPixelFormat ConvertFromMojoToMedia(
33 media::mojom::VideoFormat format); 35 media::mojom::VideoFormat format);
34 static media::VideoPixelStorage ConvertFromMojoToMedia( 36 static media::VideoPixelStorage ConvertFromMojoToMedia(
35 mojom::VideoPixelStorage storage); 37 mojom::VideoPixelStorage storage);
36 static media::ResolutionChangePolicy ConvertFromMojoToMedia( 38 static media::ResolutionChangePolicy ConvertFromMojoToMedia(
37 mojom::ResolutionChangePolicy policy); 39 mojom::ResolutionChangePolicy policy);
38 static media::PowerLineFrequency ConvertFromMojoToMedia( 40 static media::PowerLineFrequency ConvertFromMojoToMedia(
39 mojom::PowerLineFrequency frequency); 41 mojom::PowerLineFrequency frequency);
40 42
41 private: 43 private:
42 std::unique_ptr<media::VideoCaptureDevice> device_; 44 std::unique_ptr<media::VideoCaptureDevice> device_;
45 bool device_running_;
Ken Rockot(use gerrit already) 2016/09/06 16:50:26 nitty nit: My personal preference is to use in-cla
chfremer 2016/09/06 17:29:58 Done.
43 }; 46 };
44 47
45 } // namespace video_capture 48 } // namespace video_capture
46 49
47 #endif // SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_IMPL_H_ 50 #endif // SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698