Video Capture Mojo (1.4c): Handle Subsequent Access

services/video_capture/video_capture_device_factory_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_FACTORY_IMPL_H_
 #define SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_FACTORY_IMPL_H_
 
 #include <vector>
 
 #include "mojo/public/cpp/bindings/binding.h"
@@ skipping 36 matching lines @@
     DeviceEntry(DeviceEntry&& other);
     DeviceEntry& operator=(DeviceEntry&& other);
 
     mojom::VideoCaptureDeviceDescriptorPtr MakeDescriptorCopy() const;
     bool DescriptorEquals(
         const mojom::VideoCaptureDeviceDescriptorPtr& other) const;
     bool is_bound() const;
     void Bind(mojom::VideoCaptureDeviceProxyRequest request);
     void Unbind();
 
+    void OnConnectionErrorOrClose();
+
    private:
     mojom::VideoCaptureDeviceDescriptorPtr descriptor_;
     std::unique_ptr<VideoCaptureDeviceProxyImpl> device_proxy_;
     std::unique_ptr<mojo::Binding<mojom::VideoCaptureDeviceProxy>> binding_;

[Ken Rockot(use gerrit already), 2016/09/06 16:50:26]

Apologies if I missed this in a prior CL, but why the unique_ptr? If you just
owned a mojo::Binding, you could Close and re-Bind it as needed.

[Ken Rockot(use gerrit already), 2016/09/06 17:00:28]

Nevermind, thought this was a field in the impl, not in DeviceEntry. Makes
sense.

[chfremer, 2016/09/06 17:29:58]

Thanks for raising this. After offline discussion, I added a TODO and bug entry
with a feature request to make mojo::Binding a movable type.

 
     DISALLOW_COPY_AND_ASSIGN(DeviceEntry);
   };
 
   std::vector<DeviceEntry> devices_;
 };
 
 }  // namespace video_capture
 
 #endif  // SERVICES_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_FACTORY_IMPL_H_