services/video_capture/video_capture_device_proxy_impl.cc - Issue 2244763002: Video Capture Mojo (1.4a.a): Add service configurator interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/video_capture/video_capture_device_proxy_impl.cc

Issue 2244763002: Video Capture Mojo (1.4a.a): Add service configurator interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@MakeService

Patch Set: mcasas' comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« services/video_capture/public/interfaces/fake_video_capture_device_factory_configurator.mojom ('K') | « services/video_capture/video_capture_device_proxy_impl.h ('k') | services/video_capture/video_capture_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/logging.h"	5 #include "base/logging.h"

6 #include "services/video_capture/video_capture_device_impl.h"	6 #include "services/video_capture/video_capture_device_proxy_impl.h"

7	7

8 namespace video_capture {	8 namespace video_capture {

9	9

10 void VideoCaptureDeviceImpl::Start(	10 void VideoCaptureDeviceProxyImpl::Start(

11 mojom::VideoCaptureFormatPtr requested_format,	11 mojom::VideoCaptureFormatPtr requested_format,
	mcasas 2016/08/16 02:18:13 It might be easier to extract the s/VideoCaptureD It might be easier to extract the s/VideoCaptureDevice/VideoCaptureDeviceProxy/ to another CL: reviewers tend to be more responsive if they read that a particular CL introduces no code changes. chfremer 2016/08/16 16:48:02 Good point. I will split it out to a new CL. Show quoted text On 2016/08/16 02:18:13, mcasas wrote: > It might be easier to extract the > s/VideoCaptureDevice/VideoCaptureDeviceProxy/ > to another CL: reviewers tend to be more responsive > if they read that a particular CL introduces no code > changes. Good point. I will split it out to a new CL.
12 mojom::ResolutionChangePolicy resolution_change_policy,	12 mojom::ResolutionChangePolicy resolution_change_policy,

13 mojom::PowerLineFrequency power_line_frequency,	13 mojom::PowerLineFrequency power_line_frequency,

14 mojom::VideoCaptureDeviceClientPtr client) {	14 mojom::VideoCaptureDeviceClientPtr client) {

15 NOTIMPLEMENTED();	15 NOTIMPLEMENTED();

16 }	16 }

17	17

18 } // namespace video_capture	18 } // namespace video_capture

OLD	NEW