Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: components/arc/bluetooth/arc_bluetooth_bridge.cc

Issue 2244703005: arc: bluetooth: Fix advertised uuid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix service dat, fix test, add test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/bluetooth/arc_bluetooth_bridge.cc
diff --git a/components/arc/bluetooth/arc_bluetooth_bridge.cc b/components/arc/bluetooth/arc_bluetooth_bridge.cc
index 41725f6c8b92fb8a1c4f1d27031180e825bf6f15..d3f91bd5e1e654d25c9ad0441df62098acc3c5fa 100644
--- a/components/arc/bluetooth/arc_bluetooth_bridge.cc
+++ b/components/arc/bluetooth/arc_bluetooth_bridge.cc
@@ -1542,7 +1542,7 @@ ArcBluetoothBridge::GetAdvertisingData(BluetoothDevice* device) const {
advertising_data.push_back(std::move(local_name));
// ServiceUuid
- BluetoothDevice::UUIDList uuid_list = device->GetServiceDataUUIDs();
+ BluetoothDevice::UUIDList uuid_list = device->GetUUIDs();
Luis Héctor Chávez 2016/08/15 21:23:12 nit: const BluetoothDevice::UUIDList&
Luis Héctor Chávez 2016/08/15 21:25:43 ignore this, I double checked and the code is corr
if (uuid_list.size() > 0) {
mojom::BluetoothAdvertisingDataPtr service_uuids =
mojom::BluetoothAdvertisingData::New();
@@ -1552,7 +1552,7 @@ ArcBluetoothBridge::GetAdvertisingData(BluetoothDevice* device) const {
}
// Service data
- for (auto& uuid : uuid_list) {
+ for (auto& uuid : device->GetServiceDataUUIDs()) {
base::BinaryValue* data = device->GetServiceData(uuid);
if (data->GetSize() == 0)
continue;
« no previous file with comments | « no previous file | components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698