extensions/browser/api/bluetooth/bluetooth_api_utils.cc - Issue 2244693002: bluetooth: Refactor how we update based on Advertising Data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/bluetooth/bluetooth_api_utils.cc

Issue 2244693002: bluetooth: Refactor how we update based on Advertising Data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/arc/bluetooth/arc_bluetooth_bridge.cc ('K') | « device/bluetooth/test/mock_bluetooth_device.h ('k') | extensions/browser/api/bluetooth/bluetooth_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/bluetooth/bluetooth_api_utils.cc

diff --git a/extensions/browser/api/bluetooth/bluetooth_api_utils.cc b/extensions/browser/api/bluetooth/bluetooth_api_utils.cc

index f6b3b2caee158ba96544c01e141375a7bb8e2b78..7f5aa8d48a1a2b49597501cbc594abdd1087225d 100644

--- a/extensions/browser/api/bluetooth/bluetooth_api_utils.cc

+++ b/extensions/browser/api/bluetooth/bluetooth_api_utils.cc

@@ -116,10 +116,10 @@ void BluetoothDeviceToApiDevice(const device::BluetoothDevice& device,

out->connectable.reset(new bool(device.IsConnectable()));

std::vector<std::string>* string_uuids = new std::vector<std::string>();

- const device::BluetoothDevice::UUIDList& uuids = device.GetUUIDs();

- for (device::BluetoothDevice::UUIDList::const_iterator iter = uuids.begin();

- iter != uuids.end(); ++iter)

- string_uuids->push_back(iter->canonical_value());

+ const device::BluetoothDevice::UUIDSet& uuids = device.GetUUIDs();

+ for (const auto& uuid : uuids) {

+ string_uuids->push_back(uuid.canonical_value());

+ }

out->uuids.reset(string_uuids);

if (device.GetInquiryRSSI())