Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2244683002: Switching from the old to the new language detector. (Closed)

Created:
4 years, 4 months ago by Anton Bakalov
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switching from the old (CLD2) to the new (CLD3) language detector. Note: I ran tools/linux/dump-static-initializers.py on CLD3. It did not find any static initializers. BUG=624904 Committed: https://crrev.com/5b70d355c174c026f936cb5ef795b4d66c1cc4f5 Cr-Commit-Position: refs/heads/master@{#411677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/cld/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Anton Bakalov
4 years, 4 months ago (2016-08-12 14:59:55 UTC) #4
brettw
lgtm
4 years, 4 months ago (2016-08-12 16:41:32 UTC) #9
Anton Bakalov
Thanks, Brett!
4 years, 4 months ago (2016-08-12 16:43:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244683002/1
4 years, 4 months ago (2016-08-12 16:43:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 16:47:40 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 16:50:15 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b70d355c174c026f936cb5ef795b4d66c1cc4f5
Cr-Commit-Position: refs/heads/master@{#411677}

Powered by Google App Engine
This is Rietveld 408576698