Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2244673002: [regexp][liveedit] Fix inconsistent JSArrays (Closed)

Created:
4 years, 4 months ago by Jakob Kummerow
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp][liveedit] Fix inconsistent JSArrays The hand-written KeyedLoadIC_Megamorphic stub didn't care about JSArray lengths, which made it lenient towards said lengths being wrong, but it will soon fix that bug and thereby become more strict. LiveEdit: factory->NewJSArray(capacity) doesn't set a length, so set it manually. RegExp: to avoid having to take care of array length updating in the RegExpExecStub, just use a JSObject instead. Committed: https://crrev.com/bb9707c8d2f7b930ecd83d1fb7f7c3c59beaa29e Cr-Commit-Position: refs/heads/master@{#38624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -95 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/debug/liveedit.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/js/macros.py View 2 chunks +10 lines, -15 lines 0 comments Download
M src/js/regexp.js View 2 chunks +17 lines, -9 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/regexp/jsregexp.h View 3 chunks +9 lines, -17 lines 0 comments Download
M src/regexp/jsregexp.cc View 6 chunks +13 lines, -19 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 7 chunks +7 lines, -10 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
As discussed, PTAL.
4 years, 4 months ago (2016-08-12 14:01:04 UTC) #2
Yang
lgtm
4 years, 4 months ago (2016-08-12 14:06:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244673002/1
4 years, 4 months ago (2016-08-12 14:07:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 14:29:55 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 14:30:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb9707c8d2f7b930ecd83d1fb7f7c3c59beaa29e
Cr-Commit-Position: refs/heads/master@{#38624}

Powered by Google App Engine
This is Rietveld 408576698