Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2244653003: 🚀 Add dex info and static initializers to resource_sizes.py (Closed)

Created:
4 years, 4 months ago by agrieve
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dex info and static initializers to resource_sizes.py The goal is to have a single script that reports all .apk size related metrics. * Uses method_count.py to get dex info. * Already had static initializer logic, but now shows it even without --so_with_symbols_path. * Tweaks the static initializer count logic to sum up rather for all .so files rather than report the same metric repeatedly. BUG=609365 Committed: https://crrev.com/af1b0701484ff33965439440c43e620cf50a6056 Cr-Commit-Position: refs/heads/master@{#411859}

Patch Set 1 #

Patch Set 2 : Add dex info and static initializers to resource_sizes.py #

Patch Set 3 : Add dex info and static initializers to resource_sizes.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -19 lines) Patch
M build/android/method_count.py View 5 chunks +8 lines, -8 lines 0 comments Download
M build/android/resource_sizes.py View 1 6 chunks +53 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
agrieve
On 2016/08/12 18:13:45, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:rnephew@chromium.org
4 years, 4 months ago (2016-08-12 18:14:07 UTC) #3
rnephew (Reviews Here)
On 2016/08/12 18:14:07, agrieve wrote: > On 2016/08/12 18:13:45, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
4 years, 4 months ago (2016-08-12 20:27:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244653003/40001
4 years, 4 months ago (2016-08-12 20:29:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/111848)
4 years, 4 months ago (2016-08-12 20:54:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244653003/40001
4 years, 4 months ago (2016-08-13 02:02:59 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-13 02:30:07 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/af1b0701484ff33965439440c43e620cf50a6056 Cr-Commit-Position: refs/heads/master@{#411859}
4 years, 4 months ago (2016-08-13 02:31:59 UTC) #14
amineer
4 years, 4 months ago (2016-08-15 21:02:20 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2243343004/ by amineer@chromium.org.

The reason for reverting is: Causing build failures, will update tracking bug
with details..

Powered by Google App Engine
This is Rietveld 408576698