Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2244653002: gn: Use a separate flag for enabling libgnome-keyring support. (Closed)

Created:
4 years, 4 months ago by Raphael Kubo da Costa (rakuco)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina, dvadym, cfroussios, Tom Anderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Use a separate flag for enabling libgnome-keyring support. Right now, |is_desktop_linux| means GN requires libgnome-keyring to be present during the build and also at run-time. Since libgnome-keyring has been deprecated by libsecret, is used by a small number of users and is not always present on a Linux distribution (especially embedded ones), it makes sense to introduce a specific argument, |use_gnome_keyring|, to control whether the code should be used or not. At the moment, |use_gnome_keyring| defaults to on under pretty much all circumstances where checking for |is_desktop_linux| would work before: it just needs |use_glib| to be on as well, as required by libgnome-keyring itself. R=brettw@chromium.org,vabr@chromium.org,thestig@chromium.org,jochen@chromium.org BUG=466975, 602624 Committed: https://crrev.com/c4e3e52dff0f5b9dff7167a1564b0e1978d3ea2e Cr-Commit-Position: refs/heads/master@{#412246}

Patch Set 1 #

Patch Set 2 : Patch v2, drop unnecessary import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/os_crypt/BUILD.gn View 2 chunks +10 lines, -7 lines 0 comments Download
A components/os_crypt/features.gni View 1 1 chunk +11 lines, -0 lines 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
Raphael Kubo da Costa (rakuco)
PTAL. A lot of OWNERS seem to be OoO, so the reviewer list is quite ...
4 years, 4 months ago (2016-08-12 11:54:28 UTC) #2
vabr (Chromium)
I am not an OWNER of any file touched in the CL, so I'll defer ...
4 years, 4 months ago (2016-08-12 12:10:45 UTC) #3
brettw
lgtm
4 years, 4 months ago (2016-08-12 17:01:03 UTC) #6
Dirk Pranke
lgtm also. thomasanderson@ - fyi.
4 years, 4 months ago (2016-08-12 23:07:00 UTC) #8
Lei Zhang
On 2016/08/12 12:10:45, vabr (Chromium) wrote: > I am not an OWNER of any file ...
4 years, 4 months ago (2016-08-13 02:21:05 UTC) #9
blundell
-blundell@ -caitkp@ thestig is sufficient for reviewing //components/os_crypt (and is the right reviewer for it ...
4 years, 4 months ago (2016-08-16 07:19:26 UTC) #11
cfroussios
lgtm lgtm
4 years, 4 months ago (2016-08-16 09:33:41 UTC) #13
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-16 14:24:42 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244653002/20001
4 years, 4 months ago (2016-08-16 14:28:28 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 15:27:08 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 15:29:53 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4e3e52dff0f5b9dff7167a1564b0e1978d3ea2e
Cr-Commit-Position: refs/heads/master@{#412246}

Powered by Google App Engine
This is Rietveld 408576698