Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2244613002: Avoid integer overflows in FXGE_GetGlyphsBBox(). (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Avoid integer overflows in FXGE_GetGlyphsBBox(). And also CFX_RenderDevice::DrawNormalText(). BUG=637192 Committed: https://pdfium.googlesource.com/pdfium/+/19cdfe4d73370b21709aefd9dce06cf463239fa1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -27 lines) Patch
M core/fxge/ge/cfx_renderdevice.cpp View 3 chunks +29 lines, -8 lines 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 2 chunks +42 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
4 years, 4 months ago (2016-08-13 02:21:47 UTC) #6
Oliver Chang
lgtm
4 years, 4 months ago (2016-08-15 19:10:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244613002/1
4 years, 4 months ago (2016-08-15 20:47:44 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 21:33:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/19cdfe4d73370b21709aefd9dce06cf46323...

Powered by Google App Engine
This is Rietveld 408576698