Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2244593002: DevTools Security panel: Update the origin view to match the latest Material specs. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Align origin, change link to button, twiddle some more CSS. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/security/originView.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
index d5d1a420273e5ed6c197ca816a4251dbc50fa893..d89ecb2687a49aabf76399816c3ba5d04643a2ba 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
@@ -743,8 +743,8 @@ WebInspector.SecurityOriginView = function(panel, origin, originState)
this._originLockIcon.classList.add("security-property-" + originState.securityState);
// TODO(lgarron): Highlight the origin scheme. https://crbug.com/523589
originDisplay.createChild("span", "origin").textContent = origin;
- var originNetworkLink = titleSection.createChild("div", "link");
- originNetworkLink.textContent = WebInspector.UIString("View requests in Network Panel");
+ var originNetworkButton = titleSection.createChild("button", "network-button");
+ originNetworkButton.textContent = WebInspector.UIString("View requests in Network Panel");
function showOriginRequestsInNetworkPanel()
{
var parsedURL = new WebInspector.ParsedURL(origin);
@@ -759,7 +759,7 @@ WebInspector.SecurityOriginView = function(panel, origin, originState)
}
]);
}
- originNetworkLink.addEventListener("click", showOriginRequestsInNetworkPanel, false);
+ originNetworkButton.addEventListener("click", showOriginRequestsInNetworkPanel, false);
if (originState.securityDetails) {
@@ -856,7 +856,7 @@ WebInspector.SecurityOriginView = function(panel, origin, originState)
originState.certificateDetailsPromise.then(displayCertificateDetails.bind(this), displayCertificateDetailsUnavailable);
- var noteSection = this.element.createChild("div", "origin-view-section");
+ var noteSection = this.element.createChild("div", "origin-view-section first-inspected-response");
// TODO(lgarron): Fix the issue and then remove this section. See comment in SecurityPanel._processRequest().
noteSection.createChild("div").textContent = WebInspector.UIString("The security details above are from the first inspected response.");
} else if (originState.securityState !== SecurityAgent.SecurityState.Unknown) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/security/originView.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698