Issue 2244583002: [payments] address label should located at left and name label should located at right in shipping s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2244583002: [payments] address label should located at left and name label should located at right in shipping s (Closed)

Created:
4 years, 4 months ago by Hwanseung Lee

Modified:
4 years, 4 months ago

Reviewers:
please use gerrit instead, gone

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[payments] address label should located at left and name label should located at right in shipping summary section. selectedShippingName and selectedShippingAddress is not match with value. so variable name will be change. BUG=637488

Patch Set 1 #

Patch Set 2 : [payments] address label should located at left and name label should located at right in shipping … #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

please use gerrit instead

This patch needs to follow the mock in https://bugs.chromium.org/p/chromium/issues/attachment?aid=246903&inline=1.

4 years, 4 months ago (2016-08-15 17:45:58 UTC) #3

please use gerrit instead

4 years, 4 months ago (2016-08-19 19:54:58 UTC) #4

Message was sent while issue was closed.

dfalcantara will be working on a fix in http://crbug.com/637488.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages