Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2244543002: Show progress spinner when waiting for shipping options update. (Closed)

Created:
4 years, 4 months ago by please use gerrit instead
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show progress spinner when waiting for shipping options update. When user selects a shipping option in PaymentRequest UI, show a spinner. The merchant may need to round trip to a server to calculate the total, which may take considerable time, especially on slow networks. BUG=637165 Committed: https://crrev.com/b06d2272aecb90f72d35c687fbd1ef22368762e6 Cr-Commit-Position: refs/heads/master@{#411785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
please use gerrit instead
dfalcantara, ptal.
4 years, 4 months ago (2016-08-12 03:39:25 UTC) #4
please use gerrit instead
Video @ https://bugs.chromium.org/p/chromium/issues/attachment?aid=246622
4 years, 4 months ago (2016-08-12 03:39:46 UTC) #5
gone
lgtm
4 years, 4 months ago (2016-08-12 21:34:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244543002/1
4 years, 4 months ago (2016-08-12 21:41:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 21:45:24 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 21:47:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b06d2272aecb90f72d35c687fbd1ef22368762e6
Cr-Commit-Position: refs/heads/master@{#411785}

Powered by Google App Engine
This is Rietveld 408576698