Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2244503003: Add flag to force touch events to be passive during fling as a runtime feature (Closed)

Created:
4 years, 4 months ago by lanwei
Modified:
4 years, 4 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag to force touch events to be passive during fling as a runtime feature. We are forcing touchstart and first touchmove to be passive during fling as our part of intervention. Now we add a flag to turn on this feature at runtime. BUG=595327 Committed: https://crrev.com/59bb2579a58499fc1f8f9e2ccc0ef5c930d34159 Cr-Commit-Position: refs/heads/master@{#412094}

Patch Set 1 #

Total comments: 1

Patch Set 2 : set feature to be experimental #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
lanwei
dtapuska@ could you please take a look?
4 years, 4 months ago (2016-08-13 01:27:29 UTC) #8
dtapuska
lgtm % whether the feature should be enabled for experimental. https://codereview.chromium.org/2244503003/diff/1/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/2244503003/diff/1/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in#newcode154 ...
4 years, 4 months ago (2016-08-15 14:35:20 UTC) #9
lanwei
avi@ could you please take a look at content/* esprehn@ could you please take a ...
4 years, 4 months ago (2016-08-15 14:58:20 UTC) #14
lanwei
Sorry isherman@ could you please take a look at tools/metrics/*, thanks!
4 years, 4 months ago (2016-08-15 14:59:59 UTC) #15
Avi (use Gerrit)
content lgtm
4 years, 4 months ago (2016-08-15 15:14:27 UTC) #16
esprehn
lgtm
4 years, 4 months ago (2016-08-15 15:45:57 UTC) #17
Ilya Sherman
metrics changes lgtm
4 years, 4 months ago (2016-08-15 19:42:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244503003/20001
4 years, 4 months ago (2016-08-15 20:24:12 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 23:30:31 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 23:34:49 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59bb2579a58499fc1f8f9e2ccc0ef5c930d34159
Cr-Commit-Position: refs/heads/master@{#412094}

Powered by Google App Engine
This is Rietveld 408576698