mojo/public: Include gtest.h as "gtest/gtest.h", instead of via "absolute" path.

mojo/public: Include gtest.h as "gtest/gtest.h", instead of via "absolute" path.

* This allows one to put gtest in other places (e.g., as in the fuchsia
  mojo repo).
* Thus this allows merges to the fuchsia mojo repo to happen much more
  cleanly. (I.e., nearly all files will be unchanged.)
* Why does this necessarily work? gtest.h itself includes other things
  in gtest's |include| directory in the same way, so gtest's |include|
  directory better be in the include path whenever gtest is used.
* Why "gtest/gtest.h" and not <gtest/gtest.h>? i. It's not a system
  header. ii. It's not a C header (which all other .h files included
  using <...> are). iii. It's the way gtest (in particular gtest.h)
  itself includes its own headers.

Also, make a "forwarding" //mojo/public:gtest target, so that other
things in //mojo/public can use gtest without needing to know directly
where gtest is. (This again simplifies merges to the fuchsia mojo repo,
as well as making it easier to consume/build the public tests from
elsewhere.)

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/dddc0e5845959fe485ec11fc94bfecc4a4807562

[vardhan, 2016-08-11 23:43:02]

lgtm

[viettrungluu, 2016-08-11 23:44:02]

Description was changed from

==========
mojo/public: Include gtest.h as "gtest/gtest.h", instead of via "absolute" path.

* This allows one to put gtest in other places (e.g., as in the fuchsia
  mojo repo).
* Thus this allows merges to the fuchsia mojo repo to happen much more
  cleanly. (I.e., nearly all files will be unchanged.)
* Why does this necessarily work? gtest.h itself includes other things
  in gtest's |include| directory in the same way, so gtest's |include|
  directory better be in the include path whenever gtest is used.
* Why "gtest/gtest.h" and not <gtest/gtest.h>? i. It's not a system
  header. ii. It's not a C header (which all other .h files included
  using <...> are). iii. It's the way gtest (in particular gtest.h)
  itself includes its own headers.

Also, make a "forwarding" //mojo/public:gtest target, so that other
things in //mojo/public can use gtest without needing to know directly
where gtest is. (This again simplifies merges to the fuchsia mojo repo,
as well as making it easier to consume/build the public tests from
elsewhere.)

R=vardhan@google.com
==========

to

==========
mojo/public: Include gtest.h as "gtest/gtest.h", instead of via "absolute" path.

* This allows one to put gtest in other places (e.g., as in the fuchsia
  mojo repo).
* Thus this allows merges to the fuchsia mojo repo to happen much more
  cleanly. (I.e., nearly all files will be unchanged.)
* Why does this necessarily work? gtest.h itself includes other things
  in gtest's |include| directory in the same way, so gtest's |include|
  directory better be in the include path whenever gtest is used.
* Why "gtest/gtest.h" and not <gtest/gtest.h>? i. It's not a system
  header. ii. It's not a C header (which all other .h files included
  using <...> are). iii. It's the way gtest (in particular gtest.h)
  itself includes its own headers.

Also, make a "forwarding" //mojo/public:gtest target, so that other
things in //mojo/public can use gtest without needing to know directly
where gtest is. (This again simplifies merges to the fuchsia mojo repo,
as well as making it easier to consume/build the public tests from
elsewhere.)

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/dddc0e5845959fe485ec11fc94b...
==========

[viettrungluu, 2016-08-11 23:44:04]

Committed patchset #1 (id:1) manually as
dddc0e5845959fe485ec11fc94bfecc4a4807562 (presubmit successful).