Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2244463003: [layoutng] Bidirectional interoperability between layoutng and legacy layout (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Bidirectional interoperability between layoutng and legacy layout Adds a function canUseNewLayout that determines whether to use the new code, or fall back to the old layout() implementation. This mostly works for now. The main thing that still needs to be done is to correctly pass down the constraints from the constraint space. I am planning to use setOverrideContainingBlockLogical{Width,Height} for that, but I first have to fix it to not be grid-specific. Complex constraint spaces will need more thought. BUG=636993 Committed: https://crrev.com/835274ca627ccc8a2877dca52845180f950cdca9 Cr-Commit-Position: refs/heads/master@{#412815}

Patch Set 1 #

Patch Set 2 : Hack this to work #

Patch Set 3 : Positioning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 1 2 2 chunks +39 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
cbiesinger
4 years, 4 months ago (2016-08-17 18:03:16 UTC) #6
eae
LGTM
4 years, 4 months ago (2016-08-18 02:03:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244463003/40001
4 years, 4 months ago (2016-08-18 13:34:56 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-18 13:38:48 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 13:40:46 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/835274ca627ccc8a2877dca52845180f950cdca9
Cr-Commit-Position: refs/heads/master@{#412815}

Powered by Google App Engine
This is Rietveld 408576698