Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2244433003: Converted Observatory refs elements (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Replaced magic number with S.kDefaultFieldLimit const #

Patch Set 3 : Initial Tests #

Patch Set 4 : All element tested #

Total comments: 30

Patch Set 5 : Addressed comments #

Patch Set 6 : Added Unknown Object to address types VM internal not explicitly managed #

Patch Set 7 : Merged with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2120 lines, -752 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 3 4 5 6 10 chunks +42 lines, -3 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/models.dart View 1 2 3 4 5 1 chunk +15 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/action_link.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_ref.dart View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_ref_wrapper.dart View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/context_ref.dart View 1 2 3 4 1 chunk +49 lines, -21 lines 0 comments Download
D runtime/observatory/lib/src/elements/context_ref.html View 1 chunk +0 lines, -33 lines 0 comments Download
A + runtime/observatory/lib/src/elements/context_ref_wrapper.dart View 2 chunks +18 lines, -12 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.html View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/eval_box.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/eval_link.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_ref.dart View 1 2 1 chunk +84 lines, -6 lines 0 comments Download
D runtime/observatory/lib/src/elements/field_ref.html View 1 chunk +0 lines, -23 lines 0 comments Download
A + runtime/observatory/lib/src/elements/field_ref_wrapper.dart View 2 chunks +18 lines, -13 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.html View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
A runtime/observatory/lib/src/elements/helpers/any_ref.dart View 1 2 3 4 5 1 chunk +71 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/elements/icdata_ref.dart View 2 chunks +18 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/elements/icdata_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/inbound_reference.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.dart View 1 2 3 4 5 1 chunk +322 lines, -52 lines 0 comments Download
D runtime/observatory/lib/src/elements/instance_ref.html View 1 chunk +0 lines, -169 lines 0 comments Download
A runtime/observatory/lib/src/elements/instance_ref_wrapper.dart View 1 chunk +79 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 3 chunks +4 lines, -7 lines 0 comments Download
A runtime/observatory/lib/src/elements/instructions_ref.dart View 1 chunk +62 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/instructions_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/elements/local_var_descriptors_ref.dart View 1 2 3 4 1 chunk +62 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/megamorphiccache_ref.dart View 1 2 3 4 1 chunk +64 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_common.html View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/elements/objectpool_ref.dart View 1 2 3 4 2 chunks +18 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectstore_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/elements/pc_descriptors_ref.dart View 1 2 3 4 1 chunk +62 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/sentinel_value.dart View 1 2 3 4 1 chunk +72 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_ref.dart View 2 chunks +60 lines, -72 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_ref.html View 1 chunk +0 lines, -52 lines 0 comments Download
A + runtime/observatory/lib/src/elements/token_stream_ref.dart View 2 chunks +17 lines, -16 lines 0 comments Download
A + runtime/observatory/lib/src/elements/unknown_ref.dart View 1 2 3 4 5 2 chunks +16 lines, -17 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/bound_field.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/context.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/field.dart View 1 chunk +29 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/guarded.dart View 1 chunk +5 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/icdata.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/instance.dart View 1 2 2 chunks +232 lines, -1 line 0 comments Download
A + runtime/observatory/lib/src/models/objects/instructions.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/local_var_descriptors.dart View 1 chunk +2 lines, -1 line 0 comments Download
A + runtime/observatory/lib/src/models/objects/map_association.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/megamorphiccache.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/object.dart View 1 2 3 4 1 chunk +20 lines, -1 line 0 comments Download
A + runtime/observatory/lib/src/models/objects/objectpool.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/pc_descriptors.dart View 1 chunk +2 lines, -1 line 0 comments Download
A runtime/observatory/lib/src/models/objects/sentinel.dart View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/token_stream.dart View 1 chunk +2 lines, -1 line 0 comments Download
A + runtime/observatory/lib/src/models/objects/unknown.dart View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/instance.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/instance.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 4 5 23 chunks +219 lines, -64 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 4 5 6 7 chunks +27 lines, -5 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/context_ref/element_test.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/context_ref/element_test.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/field_ref/element_test.dart View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/field_ref/element_test.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/icdata_ref/element_test.dart View 1 2 3 1 chunk +7 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/icdata_ref/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/instance_ref/element_test.dart View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/instance_ref/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/instructions_ref/element_test.dart View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/instructions_ref/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/local_var_descriptor_ref/element_test.dart View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/local_var_descriptor_ref/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/megamorphiccache_ref/element_test.dart View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/megamorphiccache_ref/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/class.dart View 1 2 3 4 2 chunks +7 lines, -4 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/code.dart View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/context.dart View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/error.dart View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/field.dart View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/function.dart View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
A + runtime/observatory/tests/observatory_ui/mocks/objects/icdata.dart View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart View 1 2 3 4 1 chunk +59 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/instructions.dart View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/library.dart View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/mocks/objects/local_var_descriptors.dart View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/mocks/objects/megamorphiccache.dart View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/mocks/objects/objectpool.dart View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/mocks/objects/pc_descriptors.dart View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/script.dart View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
A + runtime/observatory/tests/observatory_ui/mocks/objects/sentinel.dart View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/mocks/objects/token_stream.dart View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/mocks/objects/unknown.dart View 1 2 3 4 5 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/instance.dart View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/observatory/tests/observatory_ui/objectpool_ref/element_test.dart View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/objectpool_ref/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.dart View 1 2 3 1 chunk +8 lines, -10 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/sentinel_value/element_test.dart View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/sentinel_value/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/token_stream_ref/element_test.dart View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/token_stream_ref/element_test.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/unknown_ref/element_test.dart View 1 2 3 4 5 1 chunk +6 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/unknown_ref/element_test.html View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
cbernaschina
4 years, 4 months ago (2016-08-12 00:08:41 UTC) #2
cbernaschina
4 years, 4 months ago (2016-08-12 00:40:52 UTC) #3
cbernaschina
4 years, 4 months ago (2016-08-12 20:04:14 UTC) #4
cbernaschina
4 years, 4 months ago (2016-08-12 21:33:16 UTC) #5
Cutch
https://codereview.chromium.org/2244433003/diff/60001/runtime/observatory/lib/src/elements/context_ref.dart File runtime/observatory/lib/src/elements/context_ref.dart (right): https://codereview.chromium.org/2244433003/diff/60001/runtime/observatory/lib/src/elements/context_ref.dart#newcode63 runtime/observatory/lib/src/elements/context_ref.dart:63: /* remove delete code. https://codereview.chromium.org/2244433003/diff/60001/runtime/observatory/lib/src/elements/instance_ref.dart File runtime/observatory/lib/src/elements/instance_ref.dart (right): https://codereview.chromium.org/2244433003/diff/60001/runtime/observatory/lib/src/elements/instance_ref.dart#newcode51 ...
4 years, 4 months ago (2016-08-15 23:27:08 UTC) #7
cbernaschina
https://codereview.chromium.org/2244433003/diff/60001/runtime/observatory/lib/src/elements/context_ref.dart File runtime/observatory/lib/src/elements/context_ref.dart (right): https://codereview.chromium.org/2244433003/diff/60001/runtime/observatory/lib/src/elements/context_ref.dart#newcode63 runtime/observatory/lib/src/elements/context_ref.dart:63: /* On 2016/08/15 23:27:07, Cutch wrote: > remove delete ...
4 years, 4 months ago (2016-08-16 00:01:44 UTC) #8
Cutch
lgtm
4 years, 4 months ago (2016-08-17 14:17:51 UTC) #9
cbernaschina
4 years, 4 months ago (2016-08-17 19:31:23 UTC) #10
cbernaschina
4 years, 4 months ago (2016-08-17 19:31:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
a1edad30ea5242225eb09382cbffc19564942a5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698