Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2959)

Unified Diff: build.ninja

Issue 224443003: Use abstract configurations to switch between opt debug settings (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: updates Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/features.gypi » ('j') | build/standalone.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build.ninja
diff --git a/test/intl/intl.status b/build.ninja
similarity index 65%
copy from test/intl/intl.status
copy to build.ninja
index 4ecbf325ada948674dd731a0fb0d87ea8824fb74..8e7b0901fef2859afc184546be76c29aa14a4362 100644
--- a/test/intl/intl.status
+++ b/build.ninja
@@ -1,4 +1,4 @@
-# Copyright 2013 the V8 project authors. All rights reserved.
+#Copyright 2014 the V8 project authors.All rights reserved.
tfarina 2014/04/05 01:52:32 nit-nit: space here between # and Copyright. btw,
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
@@ -25,18 +25,20 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+rule configure
+ description = Run GYP for $arch
+ command = PYTHONPATH=$$(pwd)/tools/generate_shim_headers:$$PYTHONPATH $
+ PYTHONPATH=$$(pwd)/build/gyp/pylib:$$PYTHONPATH $
+ GYP_GENERATORS=ninja $
+ build/gyp/gyp -Goutput_dir=out/$arch -Dv8_target_arch=$arch --depth=. -Ibuild/standalone.gypi build/all.gyp
+ generator = 1
-# The following tests use getDefaultTimeZone().
-[
-[ALWAYS, {
- 'date-format/resolved-options': [FAIL],
- 'date-format/timezone': [FAIL],
- 'general/v8Intl-exists': [FAIL],
+build out/ia32/build.ninja: configure | build/all.gyp build/features.gypi build/standalone.gypi build/toolchain.gypi samples/samples.gyp src/d8.gyp test/cctest/cctest.gyp tools/gyp/v8.gyp
+ arch = ia32
- # TODO(jochen): The following test is flaky.
- 'overrides/caching': [PASS, FAIL],
+rule recurse
+ command = ninja -C out/$arch/$mode
Nico 2014/04/04 04:55:42 So the way generator rules work is that they usual
- # BUG(2899): default locale for search fails on mac and on android.
- 'collator/default-locale': [['system == macos or arch == android_arm or arch == android_ia32', FAIL]],
-}], # ALWAYS
-]
+build ia32.release: recurse | out/ia32/build.ninja
+ arch = ia32
+ mode = Release
« no previous file with comments | « no previous file | build/features.gypi » ('j') | build/standalone.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698