Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2244413003: Revert of Collect metrics for hyphenation dictionary (Closed)

Created:
4 years, 4 months ago by kojii
Modified:
4 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Collect metrics for hyphenation dictionary (patchset #4 id:80001 of https://codereview.chromium.org/2188043004/ ) Reason for revert: Reverting as this experiment shipped in dev and we started to get the data. Original issue's description: > Collect metrics for hyphenation dictionary > > This patch is to collect metrics for hyphenation dictionary on Android > dev channel by always opening the dictionary in the line breaker. > > This patch will be reverted after the branch so that it should not be > turned on for other channels. > > BUG=605840 > > Committed: https://crrev.com/58b52fa7122127737cf15c8dd952f443d9d8b667 > Cr-Commit-Position: refs/heads/master@{#410574} TBR=eae@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605840 Committed: https://crrev.com/76f02d81beb5cf2a64306931740eb7ab5fa2b4e1 Cr-Commit-Position: refs/heads/master@{#412216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kojii
Created Revert of Collect metrics for hyphenation dictionary
4 years, 4 months ago (2016-08-16 09:37:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244413003/1
4 years, 4 months ago (2016-08-16 09:37:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 11:54:46 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76f02d81beb5cf2a64306931740eb7ab5fa2b4e1 Cr-Commit-Position: refs/heads/master@{#412216}
4 years, 4 months ago (2016-08-16 11:56:44 UTC) #6
eae
4 years, 4 months ago (2016-08-16 14:43:10 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698