Chromium Code Reviews

Issue 2244373002: s390: Allow larger Operands/Displacements/Offsets in s390 (Closed)

Created:
4 years, 4 months ago by john.yan
Modified:
4 years, 4 months ago
Reviewers:
MTBrandyberry, michael_dawson, JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: Allow larger Operands/Displacements/Offsets in s390 R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/11536212497865b503b0f2191005a947465fb265 Cr-Commit-Position: refs/heads/master@{#38640}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+152 lines, -78 lines)
M src/compiler/s390/code-generator-s390.cc View 1 chunk +7 lines, -0 lines 0 comments
M src/compiler/s390/instruction-codes-s390.h View 1 chunk +4 lines, -2 lines 0 comments
M src/compiler/s390/instruction-selector-s390.cc View 25 chunks +126 lines, -71 lines 0 comments
M src/s390/assembler-s390.h View 1 chunk +1 line, -0 lines 0 comments
M src/s390/assembler-s390.cc View 2 chunks +6 lines, -1 line 0 comments
M src/s390/disasm-s390.cc View 1 chunk +3 lines, -0 lines 0 comments
M src/s390/simulator-s390.cc View 2 chunks +5 lines, -4 lines 0 comments

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 4 months ago (2016-08-15 18:25:29 UTC) #1
JaideepBajwa
lgtm
4 years, 4 months ago (2016-08-15 18:25:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244373002/1
4 years, 4 months ago (2016-08-15 18:26:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 18:57:31 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:57:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11536212497865b503b0f2191005a947465fb265
Cr-Commit-Position: refs/heads/master@{#38640}

Powered by Google App Engine