Chromium Code Reviews
DescriptionMerge "arc: Custom notification improvements"
> - Install a pre target event handler to notification surface window
> to forward events to hosting ArcCustomNotificationView;
> - Only show close button when mouse hovering;
> - Add SlideHelper to observe slide transform/animation and swap between
> a notification surface copy and real surface when a slide starts/stops;
>
> BUG=635566, 636625
> TEST=Manual. Close button only shows up when mouse hovering. Backspace/delete
> key dismisses the custom notification. Swipe gesture works as regular
> Chrome notification. Closing via close button in message list does not crash.
>
> Review-Url: https://codereview.chromium.org/2221073002
> Cr-Commit-Position: refs/heads/master@{#411272}
> (cherry picked from commit 416f1f674c873e3b58963e64a2ef01e52dcfbe5e)
Committed: https://chromium.googlesource.com/chromium/src/+/04d983055adc49b17a9e6a4c08b03104c1453098
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||