Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2244333002: Merge "arc: Custom notification improvements" (Closed)

Created:
4 years, 4 months ago by xiyuan
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Merge "arc: Custom notification improvements" > - Install a pre target event handler to notification surface window > to forward events to hosting ArcCustomNotificationView; > - Only show close button when mouse hovering; > - Add SlideHelper to observe slide transform/animation and swap between > a notification surface copy and real surface when a slide starts/stops; > > BUG=635566, 636625 > TEST=Manual. Close button only shows up when mouse hovering. Backspace/delete > key dismisses the custom notification. Swipe gesture works as regular > Chrome notification. Closing via close button in message list does not crash. > > Review-Url: https://codereview.chromium.org/2221073002 > Cr-Commit-Position: refs/heads/master@{#411272} > (cherry picked from commit 416f1f674c873e3b58963e64a2ef01e52dcfbe5e) Committed: https://chromium.googlesource.com/chromium/src/+/04d983055adc49b17a9e6a4c08b03104c1453098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -15 lines) Patch
M ui/arc/BUILD.gn View 1 chunk +7 lines, -3 lines 0 comments Download
M ui/arc/arc.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/arc/notification/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.h View 2 chunks +22 lines, -2 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 9 chunks +158 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
4 years, 4 months ago (2016-08-15 17:45:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04d983055adc49b17a9e6a4c08b03104c1453098.

Powered by Google App Engine
This is Rietveld 408576698