Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 2244313002: DBC: Fleshing out the polymorphic instance call instruction (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/constants_dbc.h ('k') | runtime/vm/intermediate_language_dbc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc
index 3a1bc7d2b88d83ef71bfedcb72f0f05ad4444b10..8367316db4b53b12f8c01aa917aaeefb295551ad 100644
--- a/runtime/vm/flow_graph_compiler.cc
+++ b/runtime/vm/flow_graph_compiler.cc
@@ -990,12 +990,15 @@ void FlowGraphCompiler::EmitDeopt(intptr_t deopt_id,
uint32_t flags) {
ASSERT(is_optimizing());
ASSERT(!intrinsic_mode());
+ // The pending deoptimization environment may be changed after this deopt is
+ // emitted, so we need to make a copy.
+ Environment* env_copy =
+ pending_deoptimization_env_->DeepCopy(zone());
CompilerDeoptInfo* info =
new(zone()) CompilerDeoptInfo(deopt_id,
reason,
flags,
- pending_deoptimization_env_);
-
+ env_copy);
deopt_infos_.Add(info);
assembler()->Deopt(0, /*is_eager =*/ 1);
info->set_pc_offset(assembler()->CodeSize());
« no previous file with comments | « runtime/vm/constants_dbc.h ('k') | runtime/vm/intermediate_language_dbc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698