Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2244313002: DBC: Fleshing out the polymorphic instance call instruction (Closed)

Created:
4 years, 4 months ago by zra
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Fleshing out the polymorphic instance call instruction R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/c75200774b758ff4beed8b986cab41981412764e

Patch Set 1 #

Patch Set 2 : Remove assert. Tests pass. #

Patch Set 3 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -28 lines) Patch
M runtime/vm/constants_dbc.h View 3 chunks +14 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 1 2 2 chunks +46 lines, -26 lines 0 comments Download
M runtime/vm/locations.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zra
I tried making PushPolymorphicInstanceCall also do the call, but the return instruction expects the instruction ...
4 years, 4 months ago (2016-08-15 22:45:41 UTC) #2
zra
This change is ready for review. PTAL.
4 years, 4 months ago (2016-08-16 16:44:11 UTC) #4
Vyacheslav Egorov (Google)
lgtm
4 years, 4 months ago (2016-08-16 17:30:58 UTC) #5
zra
4 years, 4 months ago (2016-08-16 18:21:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c75200774b758ff4beed8b986cab41981412764e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698