Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2244253002: Rename |pid| to |child_id| in SSLHostStateDelegate (Closed)

Created:
4 years, 4 months ago by estark
Modified:
4 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename |pid| to |child_id| in SSLHostStateDelegate This argument refers to a child process host ID, not an OS process ID, so |child_id| is a more accurate name. BUG=637080 Committed: https://crrev.com/195d077434c640a296b94a53b05e4ac9999566ed Cr-Commit-Position: refs/heads/master@{#411984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M android_webview/browser/aw_ssl_host_state_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/aw_ssl_host_state_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M content/public/browser/ssl_host_state_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/mock_ssl_host_state_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/mock_ssl_host_state_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
estark
jam, PTAL? Follow-up to https://codereview.chromium.org/2225213004/
4 years, 4 months ago (2016-08-15 14:52:48 UTC) #3
jam
lgtm
4 years, 4 months ago (2016-08-15 16:32:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244253002/1
4 years, 4 months ago (2016-08-15 16:33:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 18:06:09 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:11:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/195d077434c640a296b94a53b05e4ac9999566ed
Cr-Commit-Position: refs/heads/master@{#411984}

Powered by Google App Engine
This is Rietveld 408576698