Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2244243003: Renable ShutdownHandlesWindowActivation on non-Windows platforms. (Closed)

Created:
4 years, 4 months ago by Bret
Modified:
4 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renable ShutdownHandlesWindowActivation on non-Windows platforms. TBR=msw BUG=637873 Committed: https://crrev.com/7686bf2e576e1c2985b8255e05ac798ebfbcf126 Cr-Commit-Position: refs/heads/master@{#412037}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M ash/shelf/shelf_layout_manager_unittest.cc View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244243003/1
4 years, 4 months ago (2016-08-15 19:56:44 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/52190)
4 years, 4 months ago (2016-08-15 19:59:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244243003/20001
4 years, 4 months ago (2016-08-15 20:10:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 20:42:43 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7686bf2e576e1c2985b8255e05ac798ebfbcf126 Cr-Commit-Position: refs/heads/master@{#412037}
4 years, 4 months ago (2016-08-15 20:53:32 UTC) #11
msw
4 years, 4 months ago (2016-08-15 21:29:49 UTC) #13
Message was sent while issue was closed.
lgtm; thanks! FYI, I only saw this via the bug. Remember to fill out the
"Reviewers:" field to alert reviewers via email, especially for TBR. I added
myself just now.

Powered by Google App Engine
This is Rietveld 408576698