Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1741)

Issue 2244233008: DevTools security panel: switch to overview on interstitials (Closed)

Created:
4 years, 4 months ago by estark
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools security panel: switch to overview on interstitials When an interstitial is shown, we hide the Origins sidebar because it isn't very useful. But we also need to switch to the Overview view when an interstitial pops up, rather than staying on the Origin view (which might have been selected on the page before the interstitial). BUG=638601 Committed: https://crrev.com/de2f3d3da495915676390ef210d05672fdb6f006 Cr-Commit-Position: refs/heads/master@{#412912}

Patch Set 1 #

Patch Set 2 : revert accidental change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector/security/origin-view-then-interstitial.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/security/origin-view-then-interstitial-expected.txt View 1 chunk +86 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
estark
dgozman, PTAL?
4 years, 4 months ago (2016-08-18 14:04:48 UTC) #6
dgozman
lgtm
4 years, 4 months ago (2016-08-18 17:44:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244233008/20001
4 years, 4 months ago (2016-08-18 19:26:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 19:31:28 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 19:40:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de2f3d3da495915676390ef210d05672fdb6f006
Cr-Commit-Position: refs/heads/master@{#412912}

Powered by Google App Engine
This is Rietveld 408576698