Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2244233003: Simplify num_heap_slots_ calculation of deserialized scopes (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify num_heap_slots_ calculation of deserialized scopes BUG=v8:5209 Committed: https://crrev.com/4be63d6dc65ff1a757cc314f78882422a8880105 Cr-Commit-Position: refs/heads/master@{#38661}

Patch Set 1 #

Patch Set 2 : Add dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/ast/scopes.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-16 12:12:42 UTC) #2
neis
lgtm
4 years, 4 months ago (2016-08-16 12:57:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2244233003/20001
4 years, 4 months ago (2016-08-16 13:13:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 13:15:01 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 13:15:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4be63d6dc65ff1a757cc314f78882422a8880105
Cr-Commit-Position: refs/heads/master@{#38661}

Powered by Google App Engine
This is Rietveld 408576698