chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h - Issue 2244223002: Determine whether to show "Add to Homescreen" dialog or WebAPK infobar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

Issue 2244223002: Determine whether to show "Add to Homescreen" dialog or WebAPK infobar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_dialog_detector Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenProcess.java ('K') | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h » ('j') | chrome/browser/android/webapps/add_to_homescreen_process.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

index 47e8d06c82e4e1ee0faf467a6f38319a623ebb04..7de34219756aba31566d0f49f97b6e32828cc91d 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

@@ -56,6 +56,9 @@ class AddToHomescreenDataFetcher

// Called when all the data needed to create a shortcut is available.

virtual void OnDataAvailable(const ShortcutInfo& info,

const SkBitmap& icon) = 0;

+ protected:

+ virtual ~Observer() {}

};

// Initialize the fetcher by requesting the information about the page from