Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2244223002: Determine whether to show "Add to Homescreen" dialog or WebAPK infobar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_dialog_detector Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index b5a951545af9be41aa2c5886e690c3c99674cf40..c294a5d2b8fe96b9b860f5bbdde270ff55498c0a 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -56,7 +56,6 @@ GURL GetShortcutUrl(content::BrowserContext* browser_context,
InstallableParams ParamsToPerformInstallableCheck(int ideal_icon_size_in_dp,
int minimum_icon_size_in_dp) {
- // TODO(hanxi): change check_installable to true for WebAPKs.
InstallableParams params;
params.ideal_icon_size_in_dp = ideal_icon_size_in_dp;
params.minimum_icon_size_in_dp = minimum_icon_size_in_dp;
@@ -173,8 +172,6 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
weak_observer_->OnUserTitleAvailable(shortcut_info_.user_title);
if (data.icon) {
- // TODO(hanxi): implement WebAPK path if shortcut_info_.url has a secure
- // scheme and data.is_installable is true.
shortcut_info_.icon_url = data.icon_url;
// base::Bind copies the arguments internally, so it is safe to pass it

Powered by Google App Engine
This is Rietveld 408576698