chrome/browser/android/chrome_jni_registrar.cc - Issue 2244223002: Determine whether to show "Add to Homescreen" dialog or WebAPK infobar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_jni_registrar.cc

Issue 2244223002: Determine whether to show "Add to Homescreen" dialog or WebAPK infobar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_dialog_detector Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java ('k') | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h » ('j') | chrome/browser/android/webapps/add_to_homescreen_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/chrome_jni_registrar.cc

diff --git a/chrome/browser/android/chrome_jni_registrar.cc b/chrome/browser/android/chrome_jni_registrar.cc

index 9b166f0ed870adc0a4577f0d942da0eb6731f259..38cd3424935c2d658c849c4b279485284b41ae1e 100644

--- a/chrome/browser/android/chrome_jni_registrar.cc

+++ b/chrome/browser/android/chrome_jni_registrar.cc

@@ -97,7 +97,7 @@

#include "chrome/browser/android/web_contents_factory.h"

#include "chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h"

#include "chrome/browser/android/webapk/webapk_update_manager.h"

-#include "chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h"

+#include "chrome/browser/android/webapps/add_to_homescreen_manager.h"

#include "chrome/browser/android/webapps/webapp_registry.h"

#include "chrome/browser/autofill/android/personal_data_manager_android.h"

#include "chrome/browser/dom_distiller/dom_distiller_service_factory_android.h"

@@ -192,8 +192,7 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {

RegisterAutoSigninFirstRunDialogAndroid},

{"AccountManagementScreenHelper", AccountManagementScreenHelper::Register},

{"AccountTrackerService", signin::android::RegisterAccountTrackerService},

- {"AddToHomescreenDialogHelper",

- AddToHomescreenDialogHelper::RegisterAddToHomescreenDialogHelper},

+ {"AddToHomescreenDialogHelper", AddToHomescreenManager::Register},

{"AfterStartupTaskUtils", RegisterAfterStartupTaskUtilsJNI},

{"AnswersImageBridge", RegisterAnswersImageBridge},

{"AppBannerInfoBarDelegateAndroid",