Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h

Issue 2244203002: Fix "report the exception" in Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup and tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h b/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h
index dae1a565cdd465f60670d0dab820860539341e5c..12dbcfaa1573e05298088672d7c4e27db06cfd0d 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ThrowException.h
@@ -33,6 +33,9 @@
namespace blink {
+class ScriptState;
+class SourceLocation;
+
// Provides utility functions to create and/or throw a V8 exception.
// Mostly a set of wrapper functions for v8::Exception class.
class CORE_EXPORT V8ThrowException {
@@ -60,6 +63,14 @@ public:
static void throwReferenceError(v8::Isolate*, const String& message);
static void throwSyntaxError(v8::Isolate*, const String& message);
static void throwTypeError(v8::Isolate*, const String& message);
+
+ static void reportException(ScriptState*, v8::Local<v8::Value> exception,
+ const String& eventMessage, v8::Local<v8::Function>);
+
+private:
+ static void reportException(ScriptState*, v8::Local<v8::Value> exception,
+ const String& eventMessage,
+ std::unique_ptr<SourceLocation>, const v8::ScriptOriginOptions&);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698