Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

Issue 2244203002: Fix "report the exception" in Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: haraken/yukishiino reviews Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
index 7e3b532277e8fb3c9bbeac5a85eed156015d9bc2..f3ed5b3764ebcaf47cc060b854aed36939aa115a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
@@ -87,6 +87,9 @@ public:
return callExtraHelper(scriptState, name, N, args).ToLocalChecked();
}
+ // Use V8ThrowException instead of this function unless absolutely needed.
+ static void throwException(v8::Isolate*, v8::Local<v8::Value> exception, const v8::ScriptOrigin&);
+
private:
static v8::MaybeLocal<v8::Value> callExtraHelper(ScriptState* scriptState, const char* name, size_t numArgs, v8::Local<v8::Value>* args)
{

Powered by Google App Engine
This is Rietveld 408576698