third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h - Issue 2244203002: Fix "report the exception" in Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

Issue 2244203002: Fix "report the exception" in Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Took approach 7 and cleanup Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

index 7e3b532277e8fb3c9bbeac5a85eed156015d9bc2..de48aa0601af260022652899cde0a80a4d056171 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

@@ -87,6 +87,8 @@ public:

return callExtraHelper(scriptState, name, N, args).ToLocalChecked();

}

+ static void throwException(v8::Isolate*, v8::Local<v8::Value> exception, const v8::ScriptOrigin&);

private:

static v8::MaybeLocal<v8::Value> callExtraHelper(ScriptState* scriptState, const char* name, size_t numArgs, v8::Local<v8::Value>* args)

{