Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

Issue 2244203002: Fix "report the exception" in Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renamed to ErrorEventDispatcher Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
index 6c7b1e3de4e39b0513efb14349dddf12a81ff0b4..ad0f5b515a1d31ef5eca17b0fe2d95908912b024 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
@@ -4,6 +4,7 @@
#include "bindings/core/v8/ScriptCustomElementDefinition.h"
+#include "bindings/core/v8/ErrorEventDispatcher.h"
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8BindingMacros.h"
@@ -202,16 +203,14 @@ HTMLElement* ScriptCustomElementDefinition::createElementSync(
"CustomElement", constructor(), isolate);
HTMLElement* element = createElementSync(document, tagName, exceptionState);
- if (exceptionState.hadException() || !element) {
+ if (exceptionState.hadException()) {
+ DCHECK(!element);
// 7. If this step throws an exception, then report the exception, ...
- {
- v8::TryCatch tryCatch(isolate);
- tryCatch.SetVerbose(true);
- exceptionState.throwIfNeeded();
- }
-
+ ErrorEventDispatcher::dispatchErrorEvent(m_scriptState.get(),
+ exceptionState, constructor().As<v8::Function>());
return CustomElement::createFailedElement(document, tagName);
}
+ DCHECK(element);
return element;
}
@@ -238,12 +237,12 @@ bool ScriptCustomElementDefinition::runConstructor(Element* element)
if (result != element) {
const String& message = "custom element constructors must call super() first and must "
"not return a different object";
- std::unique_ptr<SourceLocation> location = SourceLocation::fromFunction(constructor().As<v8::Function>());
v8::Local<v8::Value> exception = V8ThrowException::createDOMException(
m_scriptState->isolate(),
InvalidStateError,
message);
- fireErrorEvent(m_scriptState.get(), message, exception, std::move(location));
+ ErrorEventDispatcher::dispatchErrorEvent(m_scriptState.get(),
+ exception, message, constructor().As<v8::Function>());
return false;
}
@@ -268,14 +267,6 @@ Element* ScriptCustomElementDefinition::runConstructor()
return V8Element::toImplWithTypeCheck(isolate, result);
}
-void ScriptCustomElementDefinition::fireErrorEvent(ScriptState* scriptState, const String& message, v8::Local<v8::Value> exception, std::unique_ptr<SourceLocation> location)
-{
- ErrorEvent* event = ErrorEvent::create(message, std::move(location), &scriptState->world());
- V8ErrorHandler::storeExceptionOnErrorEventWrapper(scriptState, event, exception, scriptState->context()->Global());
- ExecutionContext* executionContext = scriptState->getExecutionContext();
- executionContext->reportException(event, NotSharableCrossOrigin);
-}
-
v8::Local<v8::Object> ScriptCustomElementDefinition::constructor() const
{
DCHECK(!m_constructor.isEmpty());

Powered by Google App Engine
This is Rietveld 408576698