third_party/WebKit/Source/bindings/core/v8/ExceptionState.h - Issue 2244203002: Fix "report the exception" in Custom Elements V1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

Issue 2244203002: Fix "report the exception" in Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved reportException to ScriptCustomElementDefinition.cpp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

index 0331b9688760f90cee877acb76b954c335d410fc..0db02915947f5889e43ae26d45c0cb8fe1c59230 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.h

@@ -105,6 +105,7 @@ public:

ExceptionCode code() const { return m_code; }

const String& message() const { return m_message; }

+ v8::Local<v8::Value> getException() { return m_exception.newLocal(m_isolate); }

Yuki 2016/08/18 07:57:09 m_exception may be empty. m_exception.isEmpty() ?

kojii 2016/08/18 08:06:52 Done.

bool throwIfNeeded()

{