Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp

Issue 2244203002: Fix "report the exception" in Custom Elements V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup and tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 m_exception.set(m_isolate, exception); 92 m_exception.set(m_isolate, exception);
93 } 93 }
94 94
95 void ExceptionState::throwException() 95 void ExceptionState::throwException()
96 { 96 {
97 ASSERT(!m_exception.isEmpty()); 97 ASSERT(!m_exception.isEmpty());
98 V8ThrowException::throwException(m_isolate, m_exception.newLocal(m_isolate)) ; 98 V8ThrowException::throwException(m_isolate, m_exception.newLocal(m_isolate)) ;
99 } 99 }
100 100
101 void ExceptionState::reportException(ScriptState* scriptState,
102 v8::Local<v8::Function> function)
103 {
104 DCHECK(scriptState->isolate() == m_isolate);
105 DCHECK(!m_exception.isEmpty());
106 V8ThrowException::reportException(scriptState,
107 m_exception.newLocal(m_isolate), m_message, function);
108 }
109
101 void ExceptionState::throwTypeError(const String& message) 110 void ExceptionState::throwTypeError(const String& message)
102 { 111 {
103 ASSERT(m_isolate); 112 ASSERT(m_isolate);
104 m_code = V8TypeError; 113 m_code = V8TypeError;
105 m_message = message; 114 m_message = message;
106 setException(V8ThrowException::createTypeError(m_isolate, addExceptionContex t(message))); 115 setException(V8ThrowException::createTypeError(m_isolate, addExceptionContex t(message)));
107 } 116 }
108 117
109 void ExceptionState::throwRangeError(const String& message) 118 void ExceptionState::throwRangeError(const String& message)
110 { 119 {
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 processedMessage = ExceptionMessages::failedToDeleteIndexed(interfac eName(), message); 199 processedMessage = ExceptionMessages::failedToDeleteIndexed(interfac eName(), message);
191 else if (m_context == IndexedGetterContext) 200 else if (m_context == IndexedGetterContext)
192 processedMessage = ExceptionMessages::failedToGetIndexed(interfaceNa me(), message); 201 processedMessage = ExceptionMessages::failedToGetIndexed(interfaceNa me(), message);
193 else if (m_context == IndexedSetterContext) 202 else if (m_context == IndexedSetterContext)
194 processedMessage = ExceptionMessages::failedToSetIndexed(interfaceNa me(), message); 203 processedMessage = ExceptionMessages::failedToSetIndexed(interfaceNa me(), message);
195 } 204 }
196 return processedMessage; 205 return processedMessage;
197 } 206 }
198 207
199 } // namespace blink 208 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698