Fix "report the exception" in Custom Elements V1

third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 570 matching lines @@
 
 // Store a timestamp to the cache as hint.
 void V8ScriptRunner::setCacheTimeStamp(CachedMetadataHandler* cacheHandler)
 {
     double now = WTF::currentTime();
     unsigned tag = cacheTag(CacheTagTimeStamp, cacheHandler);
     cacheHandler->clearCachedMetadata(CachedMetadataHandler::CacheLocally);
     cacheHandler->setCachedMetadata(tag, reinterpret_cast<char*>(&now), sizeof(now), CachedMetadataHandler::SendToPlatform);
 }
 
+void V8ScriptRunner::throwException(v8::Isolate* isolate, v8::Local<v8::Value> exception, const v8::ScriptOrigin& origin)
+{
+    // Use V8ThrowException instead of this function unless absolutely needed.

[Yuki, 2016/08/22 06:42:08]

Thanks for the caution, but it's better to put this caution in .h file.

+    // In order for the current TryCatch to catch this exception and
+    // call MessageCallback when SetVerbose(true), create a v8::Function
+    // that calls isolate->throwException().
+    // Unlike throwStackOverflowExceptionIfNeeded(), create a temporary Script
+    // with the specified ScriptOrigin. When the exception was created but not
+    // thrown yet, the ScriptOrigin of the thrower is set to the exception.
+    // v8::Function::New() has empty ScriptOrigin, and thus the exception will
+    // be "muted" (sanitized in our terminology) if CORS does not allow.
+    // https://html.spec.whatwg.org/multipage/webappapis.html#report-the-error
+    v8::Local<v8::Script> script = compileWithoutOptions(
+        V8CompileHistogram::Cacheability::Noncacheable, isolate,
+        v8AtomicString(isolate, "((e) => { throw e; })"), origin)
+        .ToLocalChecked();
+    v8::Local<v8::Function> thrower = runCompiledInternalScript(isolate, script)

[haraken, 2016/08/22 06:36:47]

It's silly that we have to compile the script every time. We should introduce a
V8 API that enables us to set a ScriptOrigin on v8::Function. Would you file a
bug and add a TODO?

+        .ToLocalChecked().As<v8::Function>();
+    callInternalFunction(thrower, thrower, 1, &exception, isolate);

[haraken, 2016/08/22 06:36:47]

I'd prefer creating an array.

v8::Local<v8::Value> args = { exception };
callInternalFunction(..., WTF_ARRAY_LENGTH(args), args, ...);

+}
+
 } // namespace blink