SkPDF: eliminate SkPDFCIDfont class

SkPDF: eliminate SkPDFCIDfont class

get_glyph_widths() and set_glyph_widths() combined.

set_glyph_widths() now takes a SkPDFGlyphSet*.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2244173005

Committed: https://skia.googlesource.com/skia/+/28c6d83c98473a24b8d0b0d279c43fd37ff24055

[hal.canary, 2016-08-15 21:15:32]

Description was changed from

==========
SkPDF: eliminate SkPDFCIDfont class

get_glyph_widths() and set_glyph_widths() combined.

set_glyph_widths() now takes a SkPDFGlyphSet*.
==========

to

==========
SkPDF: eliminate SkPDFCIDfont class

get_glyph_widths() and set_glyph_widths() combined.

set_glyph_widths() now takes a SkPDFGlyphSet*.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2244173005
==========

[hal.canary, 2016-08-15 21:15:38]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 21:15:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-08-15 21:15:51]

halcanary@google.com changed reviewers:
+ bungeman@google.com

[hal.canary, 2016-08-15 21:15:52]

PTAL

[commit-bot: I haz the power, 2016-08-15 21:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 21:52:04]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-08-16 14:39:30]

https://codereview.chromium.org/2244173005/diff/1/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

https://codereview.chromium.org/2244173005/diff/1/src/pdf/SkPDFFont.cpp#newco...
src/pdf/SkPDFFont.cpp:887: sk_sp<const SkAdvancedTypefaceMetrics>
SkPDFFont::GetFontMetricsWithGlyphNames(
It doesn't look like this method is used anymore?

https://codereview.chromium.org/2244173005/diff/1/src/pdf/SkPDFFont.cpp#newco...
src/pdf/SkPDFFont.cpp:894: sk_sp<const SkAdvancedTypefaceMetrics>
SkPDFFont::GetFontMetricsWithToUnicode(
Neither is this one?

[hal.canary, 2016-08-16 15:07:31]

https://codereview.chromium.org/2244173005/diff/1/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

https://codereview.chromium.org/2244173005/diff/1/src/pdf/SkPDFFont.cpp#newco...
src/pdf/SkPDFFont.cpp:887: sk_sp<const SkAdvancedTypefaceMetrics>
SkPDFFont::GetFontMetricsWithGlyphNames(
On 2016/08/16 14:39:30, bungeman-skia wrote:
> It doesn't look like this method is used anymore?

right.  removed

https://codereview.chromium.org/2244173005/diff/1/src/pdf/SkPDFFont.cpp#newco...
src/pdf/SkPDFFont.cpp:894: sk_sp<const SkAdvancedTypefaceMetrics>
SkPDFFont::GetFontMetricsWithToUnicode(
On 2016/08/16 14:39:30, bungeman-skia wrote:
> Neither is this one?

Called by add_type3_font_info()

[hal.canary, 2016-08-16 15:07:40]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 15:07:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-08-16 15:12:39]

lgtm

[commit-bot: I haz the power, 2016-08-16 15:37:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 15:37:44]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2016-08-16 17:09:33]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-08-16 17:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/2244173005/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-16 17:09:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 17:29:40]

Description was changed from

==========
SkPDF: eliminate SkPDFCIDfont class

get_glyph_widths() and set_glyph_widths() combined.

set_glyph_widths() now takes a SkPDFGlyphSet*.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2244173005
==========

to

==========
SkPDF: eliminate SkPDFCIDfont class

get_glyph_widths() and set_glyph_widths() combined.

set_glyph_widths() now takes a SkPDFGlyphSet*.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2244173005

Committed:
https://skia.googlesource.com/skia/+/28c6d83c98473a24b8d0b0d279c43fd37ff24055
==========

[commit-bot: I haz the power, 2016-08-16 17:29:41]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/28c6d83c98473a24b8d0b0d279c43fd37ff24055