[api] Add PropertyDescriptor and DefineProperty().

src/api.cc

Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 6858a325c40a86dea6b2fa130591d36c4ac09ff5..b986eb69c87cd70c78859b6657ea6f6dea31cebe 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -3672,13 +3672,6 @@ Maybe<bool> v8::Object::DefineOwnProperty(v8::Local<v8::Context> context,
   i::Handle<i::Name> key_obj = Utils::OpenHandle(*key);
   i::Handle<i::Object> value_obj = Utils::OpenHandle(*value);
 
-  if (self->IsAccessCheckNeeded() &&
-      !isolate->MayAccess(handle(isolate->context()),
-                          i::Handle<i::JSObject>::cast(self))) {
-    isolate->ReportFailedAccessCheck(i::Handle<i::JSObject>::cast(self));
-    return Nothing<bool>();
-  }
-
   i::PropertyDescriptor desc;
   desc.set_writable(!(attributes & v8::ReadOnly));
   desc.set_enumerable(!(attributes & v8::DontEnum));
@@ -3691,6 +3684,49 @@ Maybe<bool> v8::Object::DefineOwnProperty(v8::Local<v8::Context> context,
   return success;
 }
 
+Maybe<bool> v8::Object::DefineProperty(v8::Local<v8::Context> context,
+                                       v8::Local<Name> key,
+                                       const PropertyDescriptor& descriptor) {
+  PREPARE_FOR_EXECUTION_PRIMITIVE(context, Object, DefineProperty, bool);
+  auto self = Utils::OpenHandle(this);

[Jakob Kummerow, 2016/08/26 13:28:30]

nit: please don't use auto, make the type explicit. Again twice below.

+  auto key_obj = Utils::OpenHandle(*key);
+
+  i::PropertyDescriptor desc;
+  if (descriptor.has_value()) {
+    if (descriptor.value().IsEmpty()) {
+      return Nothing<bool>();
+    }
+    desc.set_value(Utils::OpenHandle(*descriptor.value()));
+  }
+  if (descriptor.has_get()) {
+    if (descriptor.get().IsEmpty()) {
+      desc.set_get(isolate->factory()->undefined_value());
+    } else {
+      desc.set_get(Utils::OpenHandle(*descriptor.get()));
+    }
+  }
+  if (descriptor.has_set()) {
+    if (descriptor.set().IsEmpty()) {
+      desc.set_set(isolate->factory()->undefined_value());
+    } else {
+      desc.set_set(Utils::OpenHandle(*descriptor.set()));
+    }
+  }
+  if (descriptor.has_enumerable()) {
+    desc.set_enumerable(descriptor.enumerable());
+  }
+  if (descriptor.has_configurable()) {
+    desc.set_configurable(descriptor.configurable());
+  }
+  if (descriptor.has_writable()) {
+    desc.set_writable(descriptor.writable());
+  }
+
+  auto success = i::JSReceiver::DefineOwnProperty(isolate, self, key_obj, &desc,
+                                                  i::Object::DONT_THROW);
+  RETURN_ON_FAILED_EXECUTION_PRIMITIVE(bool);
+  return success;
+}
 
 MUST_USE_RESULT
 static i::MaybeHandle<i::Object> DefineObjectProperty(