Issue 22441004: [MediaGalleries] Introduce an AV-checking base class for copy-move validation

Issue 22441004: [MediaGalleries] Introduce an AV-checking base class for copy-move validation (Closed)

Created:
7 years, 4 months ago by Greg Billock

Modified:
7 years, 4 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, Lei Zhang, tzik+watch_chromium.org, tommycli, Greg Billock, kinuko+watch

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[MediaGalleries] Introduce an AV-checking base class for copy-move validation R=vandebo@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216311

Patch Set 3 : missing header #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -20 lines)			Patch
A	chrome/browser/media_galleries/fileapi/av_scanning_file_validator.h	View		1 chunk	+37 lines, -0 lines	0 comments	Download
A	chrome/browser/media_galleries/fileapi/av_scanning_file_validator.cc	View	1 2	1 chunk	+81 lines, -0 lines	0 comments	Download
M	chrome/browser/media_galleries/fileapi/supported_image_type_validator.h	View		4 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

https://codereview.chromium.org/22441004/diff/1/chrome/browser/media_galleries/fileapi/av_scanning_file_validator.cc File chrome/browser/media_galleries/fileapi/av_scanning_file_validator.cc (right): https://codereview.chromium.org/22441004/diff/1/chrome/browser/media_galleries/fileapi/av_scanning_file_validator.cc#newcode40 chrome/browser/media_galleries/fileapi/av_scanning_file_validator.cc:40: return hr; We don't want to return hr here. ...

7 years, 4 months ago (2013-08-07 18:36:01 UTC) #2

Greg Billock

7 years, 4 months ago (2013-08-07 18:41:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/22441004/12001

7 years, 4 months ago (2013-08-07 19:15:00 UTC) #5

Message was sent while issue was closed.

Change committed as 216311

Expand Messages | Collapse Messages