Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5041)

Unified Diff: chrome/chrome_browser.gypi

Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 5e15a5a023a44030f4b90246386923d2228141c3..f295966a0a482c2ff67c8cfd512af5dc8f0c1546 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -2104,7 +2104,6 @@
'android/java/src/org/chromium/chrome/browser/signin/SigninManager.java',
'android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java',
'android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java',
- 'android/java/src/org/chromium/chrome/browser/spellchecker/SpellCheckerSessionBridge.java',
'android/java/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProvider.java',
'android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java',
'android/java/src/org/chromium/chrome/browser/sync/SyncSessionsMetrics.java',
@@ -2950,39 +2949,18 @@
'browser/signin/signin_tracker_factory.h',
],
'chrome_browser_spellchecker_sources': [
- 'browser/spellchecker/feedback.cc',
- 'browser/spellchecker/feedback.h',
- 'browser/spellchecker/feedback_sender.cc',
- 'browser/spellchecker/feedback_sender.h',
- 'browser/spellchecker/misspelling.cc',
- 'browser/spellchecker/misspelling.h',
- 'browser/spellchecker/spellcheck_action.cc',
- 'browser/spellchecker/spellcheck_action.h',
'browser/spellchecker/spellcheck_custom_dictionary.cc',
'browser/spellchecker/spellcheck_custom_dictionary.h',
'browser/spellchecker/spellcheck_dictionary.h',
'browser/spellchecker/spellcheck_factory.cc',
'browser/spellchecker/spellcheck_factory.h',
- 'browser/spellchecker/spellcheck_host_metrics.cc',
- 'browser/spellchecker/spellcheck_host_metrics.h',
'browser/spellchecker/spellcheck_hunspell_dictionary.cc',
'browser/spellchecker/spellcheck_hunspell_dictionary.h',
'browser/spellchecker/spellcheck_message_filter.cc',
'browser/spellchecker/spellcheck_message_filter.h',
- 'browser/spellchecker/spellcheck_message_filter_platform.h',
- 'browser/spellchecker/spellcheck_message_filter_platform_android.cc',
'browser/spellchecker/spellcheck_message_filter_platform_mac.cc',
- 'browser/spellchecker/spellcheck_platform.h',
- 'browser/spellchecker/spellcheck_platform_android.cc',
- 'browser/spellchecker/spellcheck_platform_mac.mm',
'browser/spellchecker/spellcheck_service.cc',
'browser/spellchecker/spellcheck_service.h',
- 'browser/spellchecker/spellchecker_session_bridge_android.cc',
- 'browser/spellchecker/spellchecker_session_bridge_android.h',
- 'browser/spellchecker/spelling_service_client.cc',
Avi (use Gerrit) 2016/08/17 19:17:09 You added this file to components/spellcheck, and
timvolodine 2016/08/18 12:15:35 Thanks for catching this! removed in https://coder
- 'browser/spellchecker/spelling_service_client.h',
- 'browser/spellchecker/word_trimmer.cc',
- 'browser/spellchecker/word_trimmer.h',
],
'chrome_browser_ssl_sources': [
'browser/ssl/bad_clock_blocking_page.cc',
« no previous file with comments | « chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698