Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

Issue 2244083002: Componentize spellcheck [4]: spellcheck/browser and android java-side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
index 2fabbf198046aef7a675a354b1f42fb9a099eaa3..a3424b362cecb1f341c3da42f286e6ecacd19370 100644
--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
@@ -10,14 +10,14 @@
#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/profiles/profile.h"
#import "chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h"
-#include "chrome/browser/spellchecker/spellcheck_platform.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
-#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "components/prefs/pref_service.h"
+#include "components/spellcheck/browser/pref_names.h"
+#include "components/spellcheck/browser/spellcheck_platform.h"
#include "components/spellcheck/common/spellcheck_messages.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
@@ -123,8 +123,10 @@ using content::RenderViewHost;
Profile* profile = Profile::FromBrowserContext(host->GetBrowserContext());
DCHECK(profile);
NSCellStateValue checkedState =
- profile->GetPrefs()->GetBoolean(prefs::kEnableContinuousSpellcheck) ?
- NSOnState : NSOffState;
+ profile->GetPrefs()->GetBoolean(
+ spellcheck::prefs::kEnableContinuousSpellcheck)
+ ? NSOnState
+ : NSOffState;
[(id)item setState:checkedState];
}
*valid = YES;
@@ -196,8 +198,9 @@ using content::RenderViewHost;
Profile* profile = Profile::FromBrowserContext(host->GetBrowserContext());
DCHECK(profile);
PrefService* pref = profile->GetPrefs();
- pref->SetBoolean(prefs::kEnableContinuousSpellcheck,
- !pref->GetBoolean(prefs::kEnableContinuousSpellcheck));
+ pref->SetBoolean(
+ spellcheck::prefs::kEnableContinuousSpellcheck,
+ !pref->GetBoolean(spellcheck::prefs::kEnableContinuousSpellcheck));
}
// END Spellchecking methods

Powered by Google App Engine
This is Rietveld 408576698